Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky - testForceMergeWithSoftDeletesRetentionAndRecoverySource #5364 #13910

Merged
merged 1 commit into from
May 31, 2024

Conversation

sarthakaggarwal97
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 commented May 31, 2024

Description

Switching to a deterministic merge policy due to Lucene-8962

The tests are also passing with the failed seeds

  1. C75D09DC5A0C3458
Screenshot 2024-05-31 at 13 50 01
  1. 1766E6A3B733A7AA
Screenshot 2024-05-31 at 13 50 37
  1. 1000 Iterations Passed
Screenshot 2024-05-31 at 13 59 39

Related Issues

Resolves #5364

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
@github-actions github-actions bot added bug Something isn't working flaky-test Random test failure that succeeds on second run Indexing Indexing, Bulk Indexing and anything related to indexing skip-changelog labels May 31, 2024
@sarthakaggarwal97 sarthakaggarwal97 marked this pull request as ready for review May 31, 2024 08:58
Copy link
Contributor

✅ Gradle check result for 1abf7f1: SUCCESS

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.57%. Comparing base (b15cb0c) to head (1abf7f1).
Report is 326 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13910      +/-   ##
============================================
+ Coverage     71.42%   71.57%   +0.15%     
- Complexity    59978    61293    +1315     
============================================
  Files          4985     5064      +79     
  Lines        282275   288093    +5818     
  Branches      40946    41716     +770     
============================================
+ Hits         201603   206214    +4611     
- Misses        63999    64845     +846     
- Partials      16673    17034     +361     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reta reta merged commit f50121a into opensearch-project:main May 31, 2024
58 of 85 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label May 31, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 31, 2024
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit f50121a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request May 31, 2024
(cherry picked from commit f50121a)

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…rch-project#13914)

(cherry picked from commit f50121a)

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working flaky-test Random test failure that succeeds on second run Indexing Indexing, Bulk Indexing and anything related to indexing skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] InternalEngineTests.testForceMergeWithSoftDeletesRetentionAndRecoverySource failure
2 participants