Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GlobalBuildInfoPlugin for Gradle 8.8 compatibility #13922

Closed
wants to merge 1 commit into from

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Jun 1, 2024

Description

Fixes GlobalBuildInfoPlugin usage of a deprecated constructor removed in Gradle 8.8.

Related Issues

Resolves #13921

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • [ ] API changes companion pull request created.
  • [ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Daniel Widdis <widdis@gmail.com>
@github-actions github-actions bot added bug Something isn't working Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. labels Jun 1, 2024
@dbwiddis dbwiddis marked this pull request as draft June 1, 2024 08:21
@dbwiddis
Copy link
Member Author

dbwiddis commented Jun 1, 2024

Actually this fix doesn't work. They removed all public constructors, there are static builders present, but they are not compatible with earlier gradle versions. How do we handle this?

Copy link
Contributor

github-actions bot commented Jun 1, 2024

❌ Gradle check result for 35a998a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jun 1, 2024

Thanks @dbwiddis , there is a pull request already #13584 but needs more work to replace fileCollection API

@dbwiddis
Copy link
Member Author

dbwiddis commented Jun 1, 2024

Thanks @dbwiddis , there is a pull request already #13584

Apparently my search-fu didn't work very well past midnight last night. I'll close this PR.

@dbwiddis dbwiddis closed this Jun 1, 2024
@dbwiddis dbwiddis deleted the gradle8-8 branch June 3, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Opensearchplugin is not compatible with Gradle 8.8
2 participants