-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mute all flaky IndicesRequestCacheIT tests #14077
Mute all flaky IndicesRequestCacheIT tests #14077
Conversation
@sgup432 @kiranprakash154 @getsaurabh02 Just FYI. It seems likely there are underlying bugs here, but as we have been just retrying the failures and shipping code anyway, I don't think these tests are really adding any value. We should fix these issues ASAP though because I believe this is mostly new flakiness introduced in the past few months. |
These are very frequent offenders and are causing a lot of pain in CI. Related issues: - opensearch-project#11374 - opensearch-project#12308 - opensearch-project#13540 - opensearch-project#13503 - opensearch-project#13711 - opensearch-project#13949 - opensearch-project#13437 - opensearch-project#13600 Signed-off-by: Andrew Ross <andrross@amazon.com>
a1ec22f
to
cf42dbd
Compare
These are very frequent offenders and are causing a lot of pain in CI. Related issues: - #11374 - #12308 - #13540 - #13503 - #13711 - #13949 - #13437 - #13600 Signed-off-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit fbe048f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
These are very frequent offenders and are causing a lot of pain in CI. Related issues: - #11374 - #12308 - #13540 - #13503 - #13711 - #13949 - #13437 - #13600 (cherry picked from commit fbe048f) Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
These are very frequent offenders and are causing a lot of pain in CI. Related issues: - opensearch-project#11374 - opensearch-project#12308 - opensearch-project#13540 - opensearch-project#13503 - opensearch-project#13711 - opensearch-project#13949 - opensearch-project#13437 - opensearch-project#13600 Signed-off-by: Andrew Ross <andrross@amazon.com>
hi @sgup432 - can you please confirm if we need these testcases? If yes, how can we remove the flakiness as soon as possible? Have we established that the tiered caching race condition being worked on by @kiranprakash154 would resolve a subset of these testcases? thanks. |
Hi @Pallavi-AWS and @andrross, I'll get to flaky tests right after resolving the race condition bug and have a fix soon. |
@Pallavi-AWS As @kiranprakash154 pointed out, we need these testcases. We are working on this separately to resolve all/most of these tests all at once. |
…#14239) This reverts commit fbe048f. Muting these tests was only intended to be temporary to unblock the 2.15 release. (cherry picked from commit 90ef844) Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…t#14077)" (opensearch-project#14238) This reverts commit fbe048f. Muting these tests was only intended to be temporary to unblock the 2.15 release. Signed-off-by: Andrew Ross <andrross@amazon.com>
…opensearch-project#14082) These are very frequent offenders and are causing a lot of pain in CI. Related issues: - opensearch-project#11374 - opensearch-project#12308 - opensearch-project#13540 - opensearch-project#13503 - opensearch-project#13711 - opensearch-project#13949 - opensearch-project#13437 - opensearch-project#13600 (cherry picked from commit fbe048f) Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <kkewwei@163.com>
…t#14077)" (opensearch-project#14238) (opensearch-project#14239) This reverts commit fbe048f. Muting these tests was only intended to be temporary to unblock the 2.15 release. (cherry picked from commit 90ef844) Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <kkewwei@163.com>
These are very frequent offenders and are causing a lot of pain in CI. Related issues: - opensearch-project#11374 - opensearch-project#12308 - opensearch-project#13540 - opensearch-project#13503 - opensearch-project#13711 - opensearch-project#13949 - opensearch-project#13437 - opensearch-project#13600 Signed-off-by: Andrew Ross <andrross@amazon.com>
…t#14077)" (opensearch-project#14238) This reverts commit fbe048f. Muting these tests was only intended to be temporary to unblock the 2.15 release. Signed-off-by: Andrew Ross <andrross@amazon.com>
These are very frequent offenders and are causing a lot of pain in CI.
Related issues:
org.opensearch.indices.IndicesRequestCacheIT.testCacheCleanupOnEqualStalenessAndThreshold
is flaky #13503Check List
Functionality includes testing.API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.