-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read write ephemeral objects for remote publication of cluster state #14089
Read write ephemeral objects for remote publication of cluster state #14089
Conversation
❌ Gradle check result for 4671704: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for d7c25e6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Outdated
Show resolved
Hide resolved
d7c25e6
to
3467ca7
Compare
❌ Gradle check result for 3467ca7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
❌ Gradle check result for 0391436: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 7a05c8e: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14089 +/- ##
============================================
+ Coverage 71.42% 71.64% +0.22%
- Complexity 59978 61967 +1989
============================================
Files 4985 5117 +132
Lines 282275 291579 +9304
Branches 40946 42150 +1204
============================================
+ Hits 201603 208902 +7299
- Misses 63999 65421 +1422
- Partials 16673 17256 +583 ☔ View full report in Codecov by Sentry. |
PR has an approval from @Bukhtawar . Providing it another approval to unblock merge as some test fix went in since the last approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Providing approval to unblock merge.
990ddc3
into
opensearch-project:main
…14089) * Read and write ephemeral objects for remote publication Co-authored-by: Sooraj Sinha <soosinha@amazon.com> Co-authored-by: Arpit Bandejiya <abandeji@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add serde logic for hashes of consistent settings Signed-off-by: Sooraj Sinha <soosinha@amazon.com> * Add formattedName to readAsync for IndexMetadata Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 990ddc3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…pensearch-project#14089) * Read and write ephemeral objects for remote publication Co-authored-by: Sooraj Sinha <soosinha@amazon.com> Co-authored-by: Arpit Bandejiya <abandeji@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add serde logic for hashes of consistent settings Signed-off-by: Sooraj Sinha <soosinha@amazon.com> * Add formattedName to readAsync for IndexMetadata Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 990ddc3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…14089) (#14209) * Read and write ephemeral objects for remote publication Co-authored-by: Sooraj Sinha <soosinha@amazon.com> Co-authored-by: Arpit Bandejiya <abandeji@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add serde logic for hashes of consistent settings Signed-off-by: Sooraj Sinha <soosinha@amazon.com> * Add formattedName to readAsync for IndexMetadata Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 990ddc3) Signed-off-by: Shivansh Arora <hishiv@amazon.com>
…14089) (#14207) * Read and write ephemeral objects for remote publication Co-authored-by: Sooraj Sinha <soosinha@amazon.com> Co-authored-by: Arpit Bandejiya <abandeji@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add serde logic for hashes of consistent settings Signed-off-by: Sooraj Sinha <soosinha@amazon.com> * Add formattedName to readAsync for IndexMetadata Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 990ddc3) Signed-off-by: Shivansh Arora <hishiv@amazon.com>
…pensearch-project#14089) * Read and write ephemeral objects for remote publication Co-authored-by: Sooraj Sinha <soosinha@amazon.com> Co-authored-by: Arpit Bandejiya <abandeji@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add serde logic for hashes of consistent settings Signed-off-by: Sooraj Sinha <soosinha@amazon.com> * Add formattedName to readAsync for IndexMetadata Signed-off-by: Shivansh Arora <hishiv@amazon.com>
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Show resolved
Hide resolved
…pensearch-project#14089) (opensearch-project#14207) * Read and write ephemeral objects for remote publication Co-authored-by: Sooraj Sinha <soosinha@amazon.com> Co-authored-by: Arpit Bandejiya <abandeji@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add serde logic for hashes of consistent settings Signed-off-by: Sooraj Sinha <soosinha@amazon.com> * Add formattedName to readAsync for IndexMetadata Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 990ddc3) Signed-off-by: Shivansh Arora <hishiv@amazon.com> Signed-off-by: kkewwei <kkewwei@163.com>
…pensearch-project#14089) * Read and write ephemeral objects for remote publication Co-authored-by: Sooraj Sinha <soosinha@amazon.com> Co-authored-by: Arpit Bandejiya <abandeji@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add serde logic for hashes of consistent settings Signed-off-by: Sooraj Sinha <soosinha@amazon.com> * Add formattedName to readAsync for IndexMetadata Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
The changes include modification in
RemoteClusterStateService
to enable uploading the ephemeral objects required for publication of cluster state through remote store. Also, added a method to read the Cluster State Attributes such as IndexMetadata, GlobalMetadata attributes from remote store in parallel. Read will be crucial part for publication as each follower node will be downloading the updated state from remote.Related Issues
Resolves #13728
Resolves #13729
Resolves #14109
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.