Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test : RemoteMigrationIndexMetadataUpdateIT.testRemoteIndexPathFileExistsAfterMigration #14433

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

astute-decipher
Copy link
Contributor

@astute-decipher astute-decipher commented Jun 18, 2024

Description

  • In RemoteMigrationIndexMetadataUpdateIT.testRemoteIndexPathFileExistsAfterMigration test we validate if remote index path file exists on the migrated index on remote node.
  • In test, we are first creating a DocRep cluster with 1 cluster manager , 2 Data nodes. After that we add 1 remote cluster manager node and 2 remote nodes.
  • So previously in order to elect remote cluster manager as active master we were terminating docRep cluster manager, due to which we were running into issue NodeClosedException when other nodes try to join the cluster.
  • To avoid the issue we will be using voting config exclusion to elect the remote cluster manager instead of terminating it.
  • With the fix, the flaky test ran for 5500+ iterations without failing locally.

Related Issues

Resolves #13939

Check List

  • [ ] Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ster node

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
@github-actions github-actions bot added bug Something isn't working flaky-test Random test failure that succeeds on second run Storage:Remote labels Jun 18, 2024
@astute-decipher astute-decipher self-assigned this Jun 18, 2024
Copy link
Contributor

❕ Gradle check result for 9b8d70b: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.66%. Comparing base (b15cb0c) to head (9b8d70b).
Report is 450 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14433      +/-   ##
============================================
+ Coverage     71.42%   71.66%   +0.23%     
- Complexity    59978    62056    +2078     
============================================
  Files          4985     5118     +133     
  Lines        282275   291849    +9574     
  Branches      40946    42181    +1235     
============================================
+ Hits         201603   209139    +7536     
- Misses        63999    65445    +1446     
- Partials      16673    17265     +592     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit f86990d into opensearch-project:main Jun 19, 2024
63 of 64 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 19, 2024
…ng master node (#14433)

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
(cherry picked from commit f86990d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Jun 19, 2024
…ng master node (#14433) (#14449)

(cherry picked from commit f86990d)

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Jul 12, 2024
…ng master node (opensearch-project#14433)

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…ng master node (opensearch-project#14433) (opensearch-project#14449)

(cherry picked from commit f86990d)

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
…ng master node (opensearch-project#14433)

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working flaky-test Random test failure that succeeds on second run skip-changelog Storage:Remote
Projects
Status: ✅ Done
2 participants