-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Create QueryGroup API Logic #14680
Conversation
❌ Gradle check result for d849280: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 5e9db9f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for daa8c22: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ef8945b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/search/query_group/QueryGroupServiceSettings.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
8e35c7c
to
8e123f7
Compare
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14680-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d442f7c1684af2c58e3de8c9b054c65072a03bea
# Push it to GitHub
git push --set-upstream origin backport/backport-14680-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
* add logic for Create QueryGroup API Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * remove wildcard imports Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * change jvm to memeory Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify querygroup Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * fix javadoc and add more tests Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add more tests Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * fix the persist logic Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * remove inflight checks as they are not necessary Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * remove persistable interface Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify QueryGroupServiceSettings Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add in an action package in the plugin Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on commments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments on QueryGroupPersistenceService Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments on persistence service Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * fix unit test Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add IT Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add coverage Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> (cherry picked from commit d442f7c)
@ruai0511 - I was curious what conflicting changes are failing the backport. Turns out the |
* add logic for Create QueryGroup API Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * remove wildcard imports Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * change jvm to memeory Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify querygroup Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * fix javadoc and add more tests Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add more tests Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * fix the persist logic Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * remove inflight checks as they are not necessary Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * remove persistable interface Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify QueryGroupServiceSettings Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add in an action package in the plugin Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on commments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments on QueryGroupPersistenceService Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments on persistence service Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * fix unit test Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add IT Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add coverage Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> (cherry picked from commit d442f7c) Co-authored-by: Ruirui Zhang <mariazrr@amazon.com>
* add logic for Create QueryGroup API Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * remove wildcard imports Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * change jvm to memeory Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify querygroup Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * fix javadoc and add more tests Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add more tests Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * fix the persist logic Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * remove inflight checks as they are not necessary Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * remove persistable interface Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify QueryGroupServiceSettings Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add in an action package in the plugin Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on commments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments on QueryGroupPersistenceService Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments on persistence service Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * fix unit test Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add IT Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add coverage Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
* add logic for Create QueryGroup API Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * remove wildcard imports Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * change jvm to memeory Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify querygroup Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * fix javadoc and add more tests Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add more tests Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * fix the persist logic Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * remove inflight checks as they are not necessary Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * remove persistable interface Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify QueryGroupServiceSettings Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add in an action package in the plugin Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on commments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments on QueryGroupPersistenceService Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments on persistence service Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * fix unit test Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add IT Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add coverage Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
Description
This change introduces the Create QueryGroup API which we will use to enforce node level resiliency as part of this RFC: #12342. The draft PR opened for the API specs is: opensearch-project/opensearch-api-specification#356
The Create QueryGroup API schema is:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.