Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: SPI for loading ABC templates (#14659) #14784

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Backport: SPI for loading ABC templates (#14659) #14784

merged 3 commits into from
Jul 18, 2024

Conversation

mgodwan
Copy link
Member

@mgodwan mgodwan commented Jul 17, 2024

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mgodwan
SPI for loading ABC templates (opensearch-project#14659)
577f181 
* SPI for loading ABC templates

Signed-off-by: mgodwan <mgodwan@amazon.com>
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 77f7604: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 577f181: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mgodwan
Fix flaky test due to node being used across all tests
c4f8717 
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
@mgodwan mgodwan changed the title SPI for loading ABC templates (#14659) Backport: SPI for loading ABC templates (#14659) Jul 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for c4f8717: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mgodwan
Trigger Build
317e512 
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 317e512: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 84.39716% with 22 lines in your changes missing coverage. Please review.

Project coverage is 71.68%. Comparing base (a6b8be1) to head (317e512).
Report is 2 commits behind head on 2.x.

Files Patch % Lines
...r/applicationtemplates/SystemTemplatesService.java 83.58% 8 Missing and 3 partials ⚠️
...r/applicationtemplates/SystemTemplateMetadata.java 62.50% 6 Missing ⚠️
...iontemplates/ClusterStateSystemTemplateLoader.java 89.18% 2 Missing and 2 partials ⚠️
server/src/main/java/org/opensearch/node/Node.java 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #14784      +/-   ##
============================================
+ Coverage     71.58%   71.68%   +0.09%     
- Complexity    62462    62604     +142     
============================================
  Files          5106     5111       +5     
  Lines        293563   293709     +146     
  Branches      42772    42783      +11     
============================================
+ Hits         210160   210541     +381     
+ Misses        65744    65478     -266     
- Partials      17659    17690      +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgodwan mgodwan marked this pull request as ready for review July 18, 2024 03:51
@mgodwan mgodwan requested a review from VachaShah as a code owner July 18, 2024 03:51
@shwetathareja shwetathareja merged commit f2cff08 into opensearch-project:2.x Jul 18, 2024
54 checks passed
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@mgodwan @kkewwei
Backport: SPI for loading ABC templates (opensearch-project#14659) (o…
48bba1a 
…pensearch-project#14784)

* SPI for loading ABC templates (opensearch-project#14659)

* SPI for loading ABC templates

Signed-off-by: mgodwan <mgodwan@amazon.com>
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwetathareja shwetathareja shwetathareja approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgodwan @shwetathareja