Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add prefix mode verification setting for repository verification #14839

Merged
merged 1 commit into from
Jul 22, 2024
Merged

[Backport 2.x] Add prefix mode verification setting for repository verification #14839

merged 1 commit into from
Jul 22, 2024

Conversation

ashking94
Copy link
Member

Backport e288962 from #14790.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 3445a70: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ashking94
Add prefix mode verification setting for repository verification (ope…
adfb630 
…nsearch-project#14790)

* Add prefix mode verification setting for repository verification

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Add UTs and randomise prefix mode repository verification

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for adfb630: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for adfb630: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for adfb630: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.56%. Comparing base (f4dc809) to head (adfb630).
Report is 3 commits behind head on 2.x.

Files Patch % Lines
...ch/repositories/blobstore/BlobStoreRepository.java 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #14839      +/-   ##
============================================
- Coverage     71.70%   71.56%   -0.14%     
+ Complexity    62634    62514     -120     
============================================
  Files          5106     5106              
  Lines        293618   293627       +9     
  Branches      42778    42779       +1     
============================================
- Hits         210526   210125     -401     
- Misses        65462    65885     +423     
+ Partials      17630    17617      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit 4c7d94c into opensearch-project:2.x Jul 22, 2024
32 checks passed
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@ashking94 @kkewwei
Add prefix mode verification setting for repository verification (ope…
7f4e588 
…nsearch-project#14790) (opensearch-project#14839)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashking94 @gbbafna