Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling term version check on local state for all ClusterManager Read Transport Actions #14273- backport 2.x #14869

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Enabling term version check on local state for all ClusterManager Read Transport Actions #14273- backport 2.x #14869

merged 2 commits into from
Jul 23, 2024

Conversation

rajiv-kv
Copy link
Contributor

@rajiv-kv rajiv-kv commented Jul 22, 2024 •
edited
Loading

Backport :- Enabling term version check on local state for all ClusterManager Read Transport Actions #14273

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rajiv-kv
Enabling term version check on local state for all ClusterManager Rea…
63ab6a7 
…d Transport Actions (opensearch-project#14273)

* enabling term version check on local state for all admin read actions

Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 63ab6a7: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.59%. Comparing base (7e7e775) to head (974d675).
Report is 5 commits behind head on 2.x.

Files Patch % Lines
...stermanager/TransportClusterManagerNodeAction.java 72.72% 5 Missing and 1 partial ⚠️
...ster/tasks/TransportPendingClusterTasksAction.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##                2.x   #14869   +/-   ##
=========================================
  Coverage     71.59%   71.59%           
+ Complexity    62621    62532   -89     
=========================================
  Files          5110     5110           
  Lines        293685   293699   +14     
  Branches      42801    42803    +2     
=========================================
+ Hits         210265   210279   +14     
+ Misses        65801    65756   -45     
- Partials      17619    17664   +45

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock
Merge branch '2.x' into 2.x_term_all
974d675 
Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 974d675: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 974d675: ABORTED

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 974d675: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 974d675: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rajiv-kv
Copy link
Contributor Author

❌ Gradle check result for 974d675: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky Issue 14296

@rajiv-kv rajiv-kv changed the title 2.x term all - backport Enabling term version check on local state for all ClusterManager Read Transport Actions #14273- backport 2.x Jul 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 974d675: SUCCESS

@shwetathareja shwetathareja merged commit 8b10215 into opensearch-project:2.x Jul 23, 2024
33 of 34 checks passed
@rajiv-kv rajiv-kv mentioned this pull request Jul 23, 2024
Merged
3 tasks
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@rajiv-kv @dblock @kkewwei
Enabling term version check on local state for all ClusterManager Rea…
264384d 
…d Transport Actions (opensearch-project#14273) (opensearch-project#14869)

* enabling term version check on local state for all admin read actions

Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajiv-kv @dblock @shwetathareja