-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new IndexInput for multi part upload #14888
Create new IndexInput for multi part upload #14888
Conversation
❌ Gradle check result for 6694ff6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but might be good to perf test these changes
server/src/main/java/org/opensearch/repositories/blobstore/ChecksumBlobStoreFormat.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
❌ Gradle check result for 5cffa54: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
❌ Gradle check result for 8f4553b: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 8f4553b: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14888 +/- ##
============================================
- Coverage 71.81% 71.81% -0.01%
- Complexity 62643 62644 +1
============================================
Files 5159 5159
Lines 294031 294035 +4
Branches 42513 42515 +2
============================================
- Hits 211161 211153 -8
- Misses 65457 65518 +61
+ Partials 17413 17364 -49 ☔ View full report in Codecov by Sentry. |
* Create new IndexInput for multi part upload Signed-off-by: Sooraj Sinha <soosinha@amazon.com> (cherry picked from commit 2def4fd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Create new IndexInput for multi part upload Signed-off-by: Sooraj Sinha <soosinha@amazon.com> (cherry picked from commit 2def4fd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Create new IndexInput for multi part upload (cherry picked from commit 2def4fd) Signed-off-by: Sooraj Sinha <soosinha@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Create new IndexInput for multi part upload (cherry picked from commit 2def4fd) Signed-off-by: Sooraj Sinha <soosinha@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This fixed a bug, hasn't it? It should have a line in CHANGELOG. |
* Create new IndexInput for multi part upload Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
* Create new IndexInput for multi part upload Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Description
S3 Multipart upload fails for remote state objects
Related Issues
#14808
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.