Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new IndexInput for multi part upload #14888

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

soosinha
Copy link
Member

Description

S3 Multipart upload fails for remote state objects

Related Issues

#14808

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 6694ff6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but might be good to perf test these changes

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Copy link
Contributor

❌ Gradle check result for 5cffa54: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Copy link
Contributor

❌ Gradle check result for 8f4553b:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 8f4553b:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 8f4553b: SUCCESS

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.81%. Comparing base (3497081) to head (8f4553b).
Report is 4 commits behind head on main.

Files Patch % Lines
.../repositories/blobstore/ConfigBlobStoreFormat.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14888      +/-   ##
============================================
- Coverage     71.81%   71.81%   -0.01%     
- Complexity    62643    62644       +1     
============================================
  Files          5159     5159              
  Lines        294031   294035       +4     
  Branches      42513    42515       +2     
============================================
- Hits         211161   211153       -8     
- Misses        65457    65518      +61     
+ Partials      17413    17364      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwetathareja shwetathareja merged commit 2def4fd into opensearch-project:main Jul 24, 2024
31 checks passed
@shwetathareja shwetathareja added backport 2.x Backport to 2.x branch backport 2.16 labels Jul 24, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2024
* Create new IndexInput for multi part upload

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
(cherry picked from commit 2def4fd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2024
* Create new IndexInput for multi part upload

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
(cherry picked from commit 2def4fd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shwetathareja pushed a commit that referenced this pull request Jul 24, 2024
* Create new IndexInput for multi part upload


(cherry picked from commit 2def4fd)

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shwetathareja pushed a commit that referenced this pull request Jul 24, 2024
* Create new IndexInput for multi part upload


(cherry picked from commit 2def4fd)

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dblock
Copy link
Member

dblock commented Jul 24, 2024

This fixed a bug, hasn't it? It should have a line in CHANGELOG.

@shwetathareja
Copy link
Member

@dblock thats correct, we can add Changelog.md @soosinha can you add it.

harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Aug 20, 2024
* Create new IndexInput for multi part upload

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
* Create new IndexInput for multi part upload

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants