Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new IndexInput for multi part upload #14888

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Create new IndexInput for multi part upload #14888

merged 2 commits into from
Jul 24, 2024

Conversation

soosinha
Copy link
Member

Description

S3 Multipart upload fails for remote state objects

Related Issues

#14808

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 6694ff6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Bukhtawar
Bukhtawar reviewed Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but might be good to perf test these changes

@soosinha
Create new IndexInput for multi part upload
5cffa54 
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
@soosinha soosinha marked this pull request as ready for review July 23, 2024 18:35
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 5cffa54: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Bukhtawar
Copy link
Collaborator

Test Result (4 failures / +3)
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshSuccessAfterFailureInFirstAttemptAfterSnapshotAndMetadataUpload
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.classMethod
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.classMethod
org.opensearch.index.translog.transfer.BlobStoreTransferServiceTests.testUploadBlobFromInputStreamSyncFSRepo

@soosinha
Update unit tests
8f4553b 
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 8f4553b:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 8f4553b:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 8f4553b: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.81%. Comparing base (3497081) to head (8f4553b).
Report is 4 commits behind head on main.

Files Patch % Lines
.../repositories/blobstore/ConfigBlobStoreFormat.java 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #14888      +/-   ##
============================================
- Coverage     71.81%   71.81%   -0.01%     
- Complexity    62643    62644       +1     
============================================
  Files          5159     5159              
  Lines        294031   294035       +4     
  Branches      42513    42515       +2     
============================================
- Hits         211161   211153       -8     
- Misses        65457    65518      +61     
+ Partials      17413    17364      -49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwetathareja shwetathareja merged commit 2def4fd into opensearch-project:main Jul 24, 2024
31 checks passed
@shwetathareja shwetathareja added backport 2.x Backport to 2.x branch backport 2.16 labels Jul 24, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2024
@github-actions
Create new IndexInput for multi part upload (#14888)
77f13d0 
* Create new IndexInput for multi part upload

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
(cherry picked from commit 2def4fd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 24, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2024
@github-actions
Create new IndexInput for multi part upload (#14888)
937a56f 
* Create new IndexInput for multi part upload

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
(cherry picked from commit 2def4fd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 24, 2024
Merged
shwetathareja pushed a commit that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot @github-actions
Create new IndexInput for multi part upload (#14888) (#14936)
49752ed 
* Create new IndexInput for multi part upload


(cherry picked from commit 2def4fd)

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shwetathareja pushed a commit that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot @github-actions
Create new IndexInput for multi part upload (#14888) (#14937)
769fdc8 
* Create new IndexInput for multi part upload


(cherry picked from commit 2def4fd)

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dblock
Copy link
Member

dblock commented Jul 24, 2024

This fixed a bug, hasn't it? It should have a line in CHANGELOG.

@shwetathareja
Copy link
Member

@dblock thats correct, we can add Changelog.md @soosinha can you add it.

@soosinha soosinha mentioned this pull request Jul 24, 2024
Merged
3 tasks
@BrewTestBot BrewTestBot mentioned this pull request Aug 8, 2024
Merged
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Aug 20, 2024
@soosinha @harshavamsi
Create new IndexInput for multi part upload (opensearch-project#14888)
42dfe22 
* Create new IndexInput for multi part upload

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
@soosinha
Create new IndexInput for multi part upload (opensearch-project#14888)
29a7a03 
* Create new IndexInput for multi part upload

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himshikha himshikha himshikha left review comments

@Bukhtawar Bukhtawar Bukhtawar approved these changes

@shwetathareja shwetathareja shwetathareja approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch backport 2.16 skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@soosinha @Bukhtawar @dblock @shwetathareja @himshikha