Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.16] fix constant_keyword field type (#14807) #14969

Merged
merged 2 commits into from
Jul 25, 2024
Merged

[Backport 2.16] fix constant_keyword field type (#14807) #14969

merged 2 commits into from
Jul 25, 2024

Conversation

gaobinlong
Copy link
Collaborator

@gaobinlong gaobinlong commented Jul 25, 2024 •
edited
Loading

Description

Backport #14807 to 2.16.

Related Issues

#14638

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kkewwei @gaobinlong
fix constant_keyword field type (opensearch-project#14807)
36c2086 
Signed-off-by: kkewwei <kkewwei@163.com>

Signed-off-by: kkewwei <kewei.11@bytedance.com>

test

Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
(cherry picked from commit cb74371)
@gaobinlong
Copy link
Collaborator Author

@dblock I think this bug fix should be released as soon as possible so I opened this backport 2.16 PR, the bug is fatal(constant_keyword cannot work), please help to take a look, thank you!

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 4510627: SUCCESS

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 36c2086: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 36c2086: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jul 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.64%. Comparing base (b21c13e) to head (d23b0a4).
Report is 1 commits behind head on 2.16.

Additional details and impacted files 
@@             Coverage Diff              @@
##               2.16   #14969      +/-   ##
============================================
+ Coverage     71.55%   71.64%   +0.09%     
- Complexity    62711    62789      +78     
============================================
  Files          5122     5122              
  Lines        294461   294462       +1     
  Branches      42910    42910              
============================================
+ Hits         210687   210965     +278     
+ Misses        66086    65790     -296     
- Partials      17688    17707      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross
Merge branch '2.16' into backport-14807-to-2.16
d23b0a4 
Signed-off-by: Andrew Ross <andrross@amazon.com>
@prudhvigodithi prudhvigodithi mentioned this pull request Jul 25, 2024
Closed
74 tasks
dblock
dblock approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it. It's a clear bug fix and narrowly scoped. If it can make 2.16, great.

@dblock dblock added the v2.16.0 Issues and PRs related to version 2.16.0 label Jul 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for d23b0a4: ABORTED

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for d23b0a4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for d23b0a4: SUCCESS

@andrross andrross merged commit f84a26e into opensearch-project:2.16 Jul 25, 2024
36 checks passed
This was referenced Sep 6, 2024
Open
Open
Open
Open
@gaobinlong gaobinlong deleted the backport-14807-to-2.16 branch September 18, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross approved these changes

@dblock dblock dblock approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
skip-changelog v2.16.0 Issues and PRs related to version 2.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaobinlong @dblock @andrross @kkewwei