New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to skip pinned timestamp in remote segment garbage collector #15017

Merged

sachinpkale merged 6 commits into opensearch-project:main from sachinpkale:segment-gc-timestamp

Aug 27, 2024

Member

sachinpkale commented Jul 30, 2024 •

edited

Loading

Description

As part of shallow snapshot optimisations, we are introducing timestamp based implicit locking support. This feature will be called Timestamp Pinning in remote backed storage. When a timestamp is pinned, remote store garbage collectors will skip deleting data corresponding to the timestamp.
In this PR, we are making following changes to segment store garbage collection:
Fetch metadata files in reverse-chronological order
If timestamp of a metadata file md1 is > pinned_timestamp_a and the timestamp of next metadata file md2 <= pinned_timestamp_a, consider md2 to be locked by pinned timestamp.
Skip deletion of metadata files that are locked by pinned timestamps and corresponding data files
Segment garbage collection will continue to skip locked metadata files for backward compatibility.

Along with garbage collection change, this PR also introduces a method to initialise RemoteSegmentStoreDirectory to a given timestamp.

Related Issues

[Timestamp Pinning in Remote Store] Remote segment store garbage collection changes #15063

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Contributor

github-actions bot commented Jul 30, 2024

❌ Gradle check result for e8bc4e6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

sachinpkale force-pushed the segment-gc-timestamp branch from e8bc4e6 to 61f8c26 Compare

August 2, 2024 11:44

Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for 61f8c26: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

sachinpkale force-pushed the segment-gc-timestamp branch from 755f393 to b8cbc22 Compare

August 2, 2024 12:31

sachinpkale marked this pull request as ready for review

August 2, 2024 12:31

sachinpkale requested review from anasalkouz, andrross, ashking94, Bukhtawar, CEHENKLE, dblock, dbwiddis, gbbafna, kotwanikunal, mch2, msfroh, nknize, owaiskazi19, reta, Rishikesh1159, saratvemulapalli, shwetathareja, sohami and VachaShah as code owners

August 2, 2024 12:31

sachinpkale added the skip-changelog label

Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for 755f393: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for b8cbc22: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

sachinpkale commented

View reviewed changes

server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java Outdated Show resolved Hide resolved

sachinpkale force-pushed the segment-gc-timestamp branch from b8cbc22 to 2e693b8 Compare

August 5, 2024 12:18

Contributor

github-actions bot commented Aug 5, 2024

❌ Gradle check result for 8fb7cef: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

gbbafna approved these changes

View reviewed changes

gbbafna reviewed

View reviewed changes

server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java Show resolved Hide resolved

sachinpkale merged commit 46a7bb6 into opensearch-project:main

39 of 41 checks passed

This was referenced Aug 28, 2024

Add support to skip pinned timestamp in remote translog garbage collector #15416

Merged

Change RemoteSegmentStoreDirectory init at given timestamp to ignore pinned timestamp setting #15457

Merged

sachinpkale added the backport 2.x label

opensearch-trigger-bot bot pushed a commit that referenced this pull request


          Add support to skip pinned timestamp in remote segment garbage collec…

e0e3914

…tor (#15017)

---------
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
(cherry picked from commit 46a7bb6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

opensearch-trigger-bot bot mentioned this pull request

[Backport 2.x] Add support to skip pinned timestamp in remote segment garbage collector #15550

Merged

sachinpkale pushed a commit that referenced this pull request


          Add support to skip pinned timestamp in remote segment garbage collec…

171ae8e

…tor (#15017) (#15550)

---------
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
(cherry picked from commit 46a7bb6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

This was referenced Sep 6, 2024

[AUTOCUT] Gradle Check Flaky Test Report for RemoteStoreMultipartIT #15819

Open

[AUTOCUT] Gradle Check Flaky Test Report for SearchWithRandomExceptionsIT #15828

Open

[AUTOCUT] Gradle Check Flaky Test Report for DeleteSnapshotIT #15834

Open

akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request


          Add support to skip pinned timestamp in remote segment garbage collec…

9a92b24

…tor (opensearch-project#15017)

---------
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>

This was referenced Sep 11, 2024

[AUTOCUT] Gradle Check Flaky Test Report for MixedClusterClientYamlTestSuiteIT #14294

Open

[AUTOCUT] Gradle Check Flaky Test Report for MinimumClusterManagerNodesIT #14289

Open

[AUTOCUT] Gradle Check Flaky Test Report for RemoteStoreStatsIT #14310

Open

[AUTOCUT] Gradle Check Flaky Test Report for RecoveryFromGatewayIT #14304

Open

[AUTOCUT] Gradle Check Flaky Test Report for SmokeTestMultiNodeClientYamlTestSuiteIT #14408

Open

[AUTOCUT] Gradle Check Flaky Test Report for ResourceAwareTasksTests #14293

Open

[AUTOCUT] Gradle Check Flaky Test Report for RemoteMigrationIndexMetadataUpdateIT #14295

Open

[AUTOCUT] Gradle Check Flaky Test Report for RemoteIndexRecoveryIT #14323

Open

[AUTOCUT] Gradle Check Flaky Test Report for AzureBlobContainerRetriesTests #14318

Open

[AUTOCUT] Gradle Check Flaky Test Report for ChildQuerySearchIT #15907

Open

This was referenced Sep 6, 2024

[AUTOCUT] Gradle Check Flaky Test Report for IndexServiceTests #14407

Open

[AUTOCUT] Gradle Check Flaky Test Report for SearchTimeoutIT #16056

Open

opensearch-ci-bot mentioned this pull request

[AUTOCUT] Gradle Check Flaky Test Report for RemoteStoreIT #16145

Open

prudhvigodithi mentioned this pull request

[AUTOCUT] Gradle Check Flaky Test Report for MixedClusterClientYamlTestSuiteIT prudhvigodithi/opensearch-build#82

Open

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request


          Add support to skip pinned timestamp in remote segment garbage collec…

3ddab3e

…tor (opensearch-project#15017)

---------
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request


          Add support to skip pinned timestamp in remote segment garbage collec…

c8b1dcc

…tor (opensearch-project#15017)

---------
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request


          Add support to skip pinned timestamp in remote segment garbage collec…

a4b0016

…tor (opensearch-project#15017)

---------
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anshu1106 anshu1106 left review comments

linuxpi linuxpi left review comments

gbbafna gbbafna approved these changes

ajaymovva ajaymovva requested changes

anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

andrross Awaiting requested review from andrross andrross is a code owner

ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

dblock Awaiting requested review from dblock dblock is a code owner

dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

mch2 Awaiting requested review from mch2 mch2 is a code owner

msfroh Awaiting requested review from msfroh msfroh is a code owner

nknize Awaiting requested review from nknize nknize is a code owner

owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

reta Awaiting requested review from reta reta is a code owner

Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

sohami Awaiting requested review from sohami sohami is a code owner

VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

jed326 Awaiting requested review from jed326 jed326 is a code owner

jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

Labels

backport 2.x skip-changelog