Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bulk ingest NPE with empty pipeline #15033

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Fix bulk ingest NPE with empty pipeline #15033

merged 5 commits into from
Aug 6, 2024

Conversation

chishui
Copy link
Contributor

@chishui chishui commented Jul 31, 2024

Description

Fix NPE when bulk ingest with empty pipeline

Related Issues

#15032

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@chishui
Fix ingest NPE for empty pipeline
623ef8a 
Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
@chishui
Update changelog
6940c06 
Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
@chishui chishui mentioned this pull request Jul 31, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 623ef8a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 6940c06: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.77%. Comparing base (49b7cd4) to head (5557696).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #15033      +/-   ##
============================================
- Coverage     71.84%   71.77%   -0.07%     
+ Complexity    62820    62751      -69     
============================================
  Files          5169     5169              
  Lines        294664   294668       +4     
  Branches      42615    42616       +1     
============================================
- Hits         211691   211506     -185     
- Misses        65530    65777     +247     
+ Partials      17443    17385      -58

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mch2 mch2 added Indexing Indexing, Bulk Indexing and anything related to indexing bug Something isn't working labels Jul 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

❌ Gradle check result for 2ff3986: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

❌ Gradle check result for 2cf0357: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

❌ Gradle check result for 2cf0357: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@chishui
Fix UT
09630be 
Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for 09630be: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@chishui
Copy link
Contributor Author

chishui commented Aug 2, 2024

FAILURE

Failing due to - :distribution:bwc:staged:buildBwcLinuxTar - #7396

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

❌ Gradle check result for 9e21d1f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@chishui
Copy link
Contributor Author

chishui commented Aug 6, 2024

❌ Gradle check result for 9e21d1f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

#15117

@chishui
Update changelog to trigger build
5557696 
Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

✅ Gradle check result for 5557696: SUCCESS

@chishui
Copy link
Contributor Author

chishui commented Aug 6, 2024

@mch2 @andrross could you help review again?

@andrross andrross added the backport 2.x Backport to 2.x branch label Aug 6, 2024
@andrross andrross merged commit b47b401 into opensearch-project:main Aug 6, 2024
37 of 38 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 6, 2024
@github-actions
Fix bulk ingest NPE with empty pipeline (#15033)
a3b9d48 
Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
(cherry picked from commit b47b401)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 6, 2024
Merged
@chishui chishui deleted the empty-pipeline branch August 7, 2024 02:13
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Aug 20, 2024
@chishui @harshavamsi
Fix bulk ingest NPE with empty pipeline (opensearch-project#15033)
c8491dc 
Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
@chishui
Fix bulk ingest NPE with empty pipeline (opensearch-project#15033)
4294524 
Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
gaobinlong added a commit that referenced this pull request Aug 26, 2024
@opensearch-trigger-bot @github-actions @gaobinlong
Fix bulk ingest NPE with empty pipeline (#15033) (#15138)
7116a2c 
(cherry picked from commit b47b401)

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gao Binlong <gbinlong@amazon.com>
This was referenced Sep 6, 2024
Open
Open
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
@chishui @akolarkunnu
Fix bulk ingest NPE with empty pipeline (opensearch-project#15033)
1caa5a6 
Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
This was referenced Sep 9, 2024
Open
Open
@BrewTestBot BrewTestBot mentioned this pull request Sep 18, 2024
Merged
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mch2 mch2 mch2 left review comments

@andrross andrross andrross approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Indexing Indexing, Bulk Indexing and anything related to indexing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chishui @mch2 @andrross