Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RemoteCloneIndex flaky test by using sync FS repo #15037

Merged
merged 2 commits into from
Aug 3, 2024

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Jul 31, 2024

Description

If we use async FS Repo , checksum comes null in a flaky way . To stop further build failures, i have set it to not use async FS Repo . This is what we are doing for RemoteSplitIndexIT as well and originally done in #13637

The tricky thing is i am not able to repro why the checksum could come null even on 2.5k iterations and running . I will keep running this to see if it ever fails .

Related Issues

Resolves #14292

Check List

  • Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added >test-failure Test failure from CI, local build, etc. autocut flaky-test Random test failure that succeeds on second run Storage:Remote labels Jul 31, 2024
@gbbafna gbbafna added backport 2.x Backport to 2.x branch skip-changelog labels Jul 31, 2024
@gbbafna gbbafna marked this pull request as ready for review July 31, 2024 13:37
Copy link
Contributor

❌ Gradle check result for 464b4bf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 464b4bf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Aug 1, 2024

❌ Gradle check result for ac4e6a0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Aug 1, 2024

❌ Gradle check result for c903bef: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Aug 1, 2024

❌ Gradle check result for ac4e6a0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Aug 1, 2024

❌ Gradle check result for c903bef: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna
Copy link
Collaborator Author

gbbafna commented Aug 1, 2024


FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':distribution:bwc:minor:buildBwcLinuxTar'.
> Building 2.16.0 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/minor/build/bwc/checkout-2.x/distribution/archives/linux-tar/build/distributions/opensearch-min-2.16.0-SNAPSHOT-linux-x64.tar.gz

Getting build failures despite branch up to date with mainline.

@gbbafna
Copy link
Collaborator Author

gbbafna commented Aug 2, 2024

Looks like other build are also facing same issue . This is happening locally as well .

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Copy link
Contributor

github-actions bot commented Aug 3, 2024

❌ Gradle check result for 77a9bf9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Aug 3, 2024

✅ Gradle check result for 77a9bf9: SUCCESS

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.77%. Comparing base (48634bd) to head (77a9bf9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15037      +/-   ##
============================================
- Coverage     71.82%   71.77%   -0.06%     
- Complexity    62778    62810      +32     
============================================
  Files          5169     5169              
  Lines        294646   294665      +19     
  Branches      42610    42616       +6     
============================================
- Hits         211644   211497     -147     
- Misses        65573    65800     +227     
+ Partials      17429    17368      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit 47171f8 into opensearch-project:main Aug 3, 2024
34 checks passed
@gbbafna gbbafna deleted the clone-flaky branch August 3, 2024 08:33
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 3, 2024
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
(cherry picked from commit 47171f8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Aug 3, 2024
(cherry picked from commit 47171f8)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Aug 20, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut backport 2.x Backport to 2.x branch flaky-test Random test failure that succeeds on second run skip-changelog Storage:Remote >test-failure Test failure from CI, local build, etc.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[AUTOCUT] Gradle Check Flaky Test Report for RemoteCloneIndexIT
4 participants