Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add ThreadContextPermission for stashAndMergeHeaders and stashWithOrigin #15049

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jul 31, 2024

Manual backport of #15039 to 2.x that includes a deprecationLogger message to print out to unauthorized callers that access will be removed in next major version.

…gin (opensearch-project#15039)

* Add ThreadContextPermission for stashAndMergeHeaders and stashWithOrigin

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Use ThreadContextAccess

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Copy link
Contributor

✅ Gradle check result for 282717a: SUCCESS

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.59%. Comparing base (e5e1bad) to head (282717a).
Report is 10 commits behind head on 2.x.

Files Patch % Lines
...ensearch/common/util/concurrent/ThreadContext.java 57.14% 4 Missing and 2 partials ⚠️
.../org/opensearch/client/support/AbstractClient.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15049      +/-   ##
============================================
+ Coverage     71.48%   71.59%   +0.10%     
- Complexity    62677    62723      +46     
============================================
  Files          5123     5125       +2     
  Lines        294480   294558      +78     
  Branches      42912    42923      +11     
============================================
+ Hits         210518   210883     +365     
+ Misses        66286    65940     -346     
- Partials      17676    17735      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta added the v2.17.0 label Jul 31, 2024
@reta reta merged commit ee74e56 into opensearch-project:2.x Jul 31, 2024
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants