Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Publication] Add remote download stats #15291

Merged

Conversation

Arpit-Bandejiya
Copy link
Contributor

@Arpit-Bandejiya Arpit-Bandejiya commented Aug 19, 2024

Description

This PR introduces the remote download stats for the remote publication.

Sample stats on master node:

"cluster_state_stats": {
                    "overall": {
                        "update_count": 7,
                        "total_time_in_millis": 870,
                        "failed_count": 0
                    },
                    "remote_upload": {
                        "success_count": 7,
                        "failed_count": 0,
                        "total_time_in_millis": 194,
                        "indices_routing_diff_files_cleanup_attempt_failed_count": 0,
                        "index_routing_files_cleanup_attempt_failed_count": 0,
                        "cleanup_attempt_failed_count": 0
                    },
                    "remote_full_download": {
                        "success_count": 0,
                        "failed_count": 0,
                        "total_time_in_millis": 0
                    },
                    "remote_diff_download": {
                        "success_count": 0,
                        "failed_count": 0,
                        "total_time_in_millis": 0
                    }
                }

Sample stats on data node:

                "cluster_state_stats": {
                    "overall": {
                        "update_count": 0,
                        "total_time_in_millis": 0,
                        "failed_count": 0
                    },
                    "remote_full_download": {
                        "success_count": 1,
                        "failed_count": 0,
                        "total_time_in_millis": 4
                    },
                    "remote_diff_download": {
                        "success_count": 4,
                        "failed_count": 0,
                        "total_time_in_millis": 2
                    }
                }

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 268258a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Arpit-Bandejiya Arpit-Bandejiya changed the title [Remote Publication] Add remote download stats [Draft][Remote Publication] Add remote download stats Aug 19, 2024
Copy link
Contributor

❌ Gradle check result for 52aaa2f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 5d1f7cb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 "indices_routing_diff_files_cleanup_attempt_failed_count": 0,
  "index_routing_files_cleanup_attempt_failed_count": 0,

The above stats looks out of place

@Arpit-Bandejiya
Copy link
Contributor Author

 "indices_routing_diff_files_cleanup_attempt_failed_count": 0,
  "index_routing_files_cleanup_attempt_failed_count": 0,

The above stats looks out of place

Agree, these are added as part of these PR: #13909 #14684 . Should we create an issue to track this? @Bukhtawar

Copy link
Contributor

❌ Gradle check result for 4791e2b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 5994e9c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for f6d1b5a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 28ab454: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for faaece8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 1, 2024

❕ Gradle check result for 039ad00: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for b9125bf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for e6bf8db: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 2, 2024

✅ Gradle check result for a1a6b82: SUCCESS

@sachinpkale sachinpkale merged commit b54e867 into opensearch-project:main Sep 2, 2024
33 of 35 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15291-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b54e867da0e313513e90872e039717b7595cf6e4
# Push it to GitHub
git push --set-upstream origin backport/backport-15291-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15291-to-2.x.

Arpit-Bandejiya added a commit to Arpit-Bandejiya/OpenSearch that referenced this pull request Sep 2, 2024
)

---------
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

(cherry picked from commit b54e867)
Arpit-Bandejiya added a commit to Arpit-Bandejiya/OpenSearch that referenced this pull request Sep 2, 2024
)

---------
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

(cherry picked from commit b54e867)
Arpit-Bandejiya added a commit to Arpit-Bandejiya/OpenSearch that referenced this pull request Sep 2, 2024
)

---------
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

(cherry picked from commit b54e867)
Arpit-Bandejiya added a commit to Arpit-Bandejiya/OpenSearch that referenced this pull request Sep 2, 2024
)

---------
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

(cherry picked from commit b54e867)
sachinpkale pushed a commit that referenced this pull request Sep 2, 2024
---------
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

(cherry picked from commit b54e867)
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
)

---------
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants