Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Adding allowlist setting for ingest-useragent and ingest-geoip processors #15374

Merged

Conversation

saratvemulapalli
Copy link
Member

@saratvemulapalli saratvemulapalli commented Aug 23, 2024

Backport to 2.x: #15325
Adding allowlist setting for user-agent, geo-ip.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…sors (opensearch-project#15325)

* Adding allowlist setting for user-agent, geo-ip and updated tests for ingest-common.

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Remove duplicate test in ingest-common

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Adding changelog

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

---------

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Copy link
Contributor

❌ Gradle check result for 2250088: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Copy link
Contributor

❌ Gradle check result for ef0b862: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Copy link
Contributor

❌ Gradle check result for ee12522: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Copy link
Contributor

❌ Gradle check result for f0fde0a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@saratvemulapalli
Copy link
Member Author

Tests with failures:

  • org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock
  • org.opensearch.remotestore.RemoteIndexRecoveryIT.testRerouteRecovery

Copy link
Contributor

❌ Gradle check result for f0fde0a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@saratvemulapalli
Copy link
Member Author

saratvemulapalli commented Aug 23, 2024

  • What went wrong:
    Execution failed for task ':plugins:discovery-ec2:qa:amazon-ec2:yamlRestTestEnvVariables'.
    process was found dead while waiting for ports files, node{:plugins:discovery-ec2:qa:amazon-ec2:yamlRestTestEnvVariables-0}

:/

Copy link
Contributor

✅ Gradle check result for f0fde0a: SUCCESS

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.62%. Comparing base (cfd427a) to head (f0fde0a).
Report is 4 commits behind head on 2.x.

Files Patch % Lines
...org/opensearch/ingest/geoip/IngestGeoIpPlugin.java 95.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15374      +/-   ##
============================================
+ Coverage     71.59%   71.62%   +0.03%     
- Complexity    63108    63156      +48     
============================================
  Files          5173     5173              
  Lines        296034   296070      +36     
  Branches      43114    43116       +2     
============================================
+ Hits         211931   212074     +143     
+ Misses        66334    66231     -103     
+ Partials      17769    17765       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants