Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limit on number of processors in Ingest pipelines #15465

Merged
merged 18 commits into from
Sep 3, 2024
Merged

Add limit on number of processors in Ingest pipelines #15465

merged 18 commits into from
Sep 3, 2024

Conversation

anandkrrai
Copy link
Contributor

Description

Add limit on number of processors in Ingest pipelines

Related Issues

Resolves #[15464]
#15464

Check List

  • [ Y ] Functionality includes testing.
  • [ Y ] API changes companion pull request created, if applicable.
  • [ Y ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 290dbff: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

dhwanilpatel
dhwanilpatel suggested changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@dhwanilpatel dhwanilpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, Can you please add relevant UTs/ITs for the change as well?

server/src/main/java/org/opensearch/ingest/IngestPipelineValidator.java Outdated Show resolved Hide resolved
server/src/main/java/org/opensearch/ingest/IngestService.java Outdated Show resolved Hide resolved
server/src/main/java/org/opensearch/ingest/IngestPipelineValidator.java Outdated Show resolved Hide resolved
server/src/main/java/org/opensearch/action/ingest/SimulatePipelineTransportAction.java Outdated Show resolved Hide resolved
server/src/main/java/org/opensearch/ingest/IngestPipelineValidator.java Outdated Show resolved Hide resolved
Add limit on number of processors in Ingest pipelines
8a39f44 
Signed-off-by: Rai <nndri@amazon.com>
Resolved the comments
99eaf02 
Signed-off-by: Rai <nndri@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 8a39f44: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 99eaf02: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@anandkrrai
Merge branch 'main' into main
76335be 
Signed-off-by: anand kumar rai <kumar.anand.rai@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for f41573b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

anandkrrai and others added 2 commits September 3, 2024 00:57
@anandkrrai
Merge branch 'opensearch-project:main' into main
5e7685f
rebase
cf83ca7 
Signed-off-by: Rai <nndri@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

❕ Gradle check result for 5e7685f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Retry build
9149544 
Signed-off-by: Rai <nndri@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for 9149544: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shwetathareja shwetathareja mentioned this pull request Sep 3, 2024
Open
@shwetathareja
Copy link
Member

❌ Gradle check result for 9149544: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Created issue for flaky test - #15588

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

✅ Gradle check result for 9149544: SUCCESS

@shwetathareja shwetathareja merged commit 41ba00a into opensearch-project:main Sep 3, 2024
34 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 3, 2024
@github-actions
Add limit on number of processors in Ingest pipelines (#15465)
d76d2f2 
* Add limit on number of processors in Ingest pipelines

Signed-off-by: Rai <nndri@amazon.com>
(cherry picked from commit 41ba00a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 3, 2024
Merged
shwetathareja pushed a commit that referenced this pull request Sep 3, 2024
@opensearch-trigger-bot @github-actions
Add limit on number of processors in Ingest pipelines (#15465) (#15589)
dbdc151 
* Add limit on number of processors in Ingest pipelines


(cherry picked from commit 41ba00a)

Signed-off-by: Rai <nndri@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Sep 6, 2024
Open
Open
Open
Open
Open
Open
Open
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
@anandkrrai @akolarkunnu
Add limit on number of processors in Ingest pipelines (opensearch-pro…
c76b08d 
…ject#15465)

* Add limit on number of processors in Ingest pipelines

Signed-off-by: Rai <nndri@amazon.com>
This was referenced Sep 11, 2024
Open
Open
Open
Open
Open
Open
@BrewTestBot BrewTestBot mentioned this pull request Sep 18, 2024
Merged
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwetathareja shwetathareja shwetathareja approved these changes

@dhwanilpatel dhwanilpatel dhwanilpatel approved these changes

@mgodwan mgodwan mgodwan approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anandkrrai @shwetathareja @dhwanilpatel @mgodwan @shiv0408