Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashed prefix for index metadata #15476

Closed
wants to merge 2 commits into from

Conversation

soosinha
Copy link
Member

Description

Adding hashed prefix for remote index metadata files. This is required for better partitioning in backing data store.

Related Issues

NA

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 0d7845f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Copy link
Contributor

❌ Gradle check result for 5bf8aa4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 5dad535: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
@soosinha
Copy link
Member Author

Flaky test: #15117

Copy link
Contributor

❕ Gradle check result for 8f80e58: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimaryMultipleReplicaShards
      1 org.opensearch.http.SearchRestCancellationIT.testAutomaticCancellationMultiSearchDuringQueryPhase
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.93%. Comparing base (46a269e) to head (8f80e58).
Report is 58 commits behind head on main.

Files with missing lines Patch % Lines
...arch/gateway/remote/model/RemoteIndexMetadata.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15476      +/-   ##
============================================
+ Coverage     71.88%   71.93%   +0.04%     
- Complexity    63242    63318      +76     
============================================
  Files          5224     5224              
  Lines        296137   296163      +26     
  Branches      42777    42778       +1     
============================================
+ Hits         212881   213039     +158     
+ Misses        65784    65685      -99     
+ Partials      17472    17439      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +66 to +69
public BlobPath getPrefixedPath(BlobPath blobPath) {
return blobPath;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the same changes for index routing table as well to keep interfaces consistent?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of deleting the RemoteRoutingTableBlobStore class itself as that was created to add the hashed prefix itself. But I would rather do that in a follow up PR.

@soosinha
Copy link
Member Author

soosinha commented Sep 3, 2024

Closing in favour of #15575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants