-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hashed prefix for index metadata #15476
Conversation
❌ Gradle check result for 0d7845f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
❌ Gradle check result for 5bf8aa4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 5dad535: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Flaky test: #15117 |
❕ Gradle check result for 8f80e58: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15476 +/- ##
============================================
+ Coverage 71.88% 71.93% +0.04%
- Complexity 63242 63318 +76
============================================
Files 5224 5224
Lines 296137 296163 +26
Branches 42777 42778 +1
============================================
+ Hits 212881 213039 +158
+ Misses 65784 65685 -99
+ Partials 17472 17439 -33 ☔ View full report in Codecov by Sentry. |
public BlobPath getPrefixedPath(BlobPath blobPath) { | ||
return blobPath; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the same changes for index routing table as well to keep interfaces consistent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of deleting the RemoteRoutingTableBlobStore class itself as that was created to add the hashed prefix itself. But I would rather do that in a follow up PR.
Closing in favour of #15575 |
Description
Adding hashed prefix for remote index metadata files. This is required for better partitioning in backing data store.
Related Issues
NA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.