Remove some unused code in the search backpressure package #15518
+1
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
gaobinlong
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
jainankitk and
linuxpi
as code owners
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15518 +/- ##
============================================
+ Coverage 71.92% 71.93% +0.01%
+ Complexity 63561 63498 -63
============================================
Files 5244 5246 +2
Lines 296942 296958 +16
Branches 42887 42888 +1
============================================
+ Hits 213564 213621 +57
+ Misses 65930 65818 -112
- Partials 17448 17519 +71 ☔ View full report in Codecov by Sentry. |
reta
reviewed
Aug 30, 2024
server/src/main/java/org/opensearch/search/backpressure/SearchBackpressureService.java
Show resolved
Hide resolved
reta
approved these changes
Aug 30, 2024
reta
added
enhancement
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
* Remove some unused code in the search backpressure package Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Add change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> (cherry picked from commit 1d5082e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Aug 30, 2024
…15525) * Remove some unused code in the search backpressure package * Add change log * Modify change log --------- (cherry picked from commit 1d5082e) Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
…h-project#15518) * Remove some unused code in the search backpressure package Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Add change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When diving deep into the bug #15495, I found some unused code in the search backpressure package, we need to remove them.
Related Issues
#15495
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.