-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add request failure listener to track failures at query group level #15527
add request failure listener to track failures at query group level #15527
Conversation
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
❌ Gradle check result for 3574e3c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 3cbe8bb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for e4e697b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15527 +/- ##
============================================
- Coverage 72.01% 71.92% -0.09%
+ Complexity 63603 63590 -13
============================================
Files 5247 5247
Lines 297186 297352 +166
Branches 42939 42981 +42
============================================
- Hits 214023 213875 -148
- Misses 65610 65849 +239
- Partials 17553 17628 +75 ☔ View full report in Codecov by Sentry. |
server/src/main/java/org/opensearch/wlm/listeners/WorkloadManagementRequestFailureListener.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/wlm/stats/QueryGroupStats.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for fd8f3f5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
❌ Gradle check result for d89422b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15527-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 579f2aaef81cdee80028fceba1f509dc69e108c6
# Push it to GitHub
git push --set-upstream origin backport/backport-15527-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…oject#15527) * add workload managementRequestFailureListener Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add unit tests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add CHANGELOG Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add missing javadoc Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * refactor Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * address comments Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * rename listener instance Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
* add workload managementRequestFailureListener * add unit tests * add CHANGELOG * add missing javadoc * refactor * address comments * rename listener instance --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…oject#15527) * add workload managementRequestFailureListener Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add unit tests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add CHANGELOG Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add missing javadoc Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * refactor Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * address comments Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * rename listener instance Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…oject#15527) * add workload managementRequestFailureListener Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add unit tests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add CHANGELOG Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add missing javadoc Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * refactor Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * address comments Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * rename listener instance Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…oject#15527) * add workload managementRequestFailureListener Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add unit tests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add CHANGELOG Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add missing javadoc Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * refactor Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * address comments Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * rename listener instance Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…oject#15527) * add workload managementRequestFailureListener Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add unit tests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add CHANGELOG Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add missing javadoc Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * refactor Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * address comments Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * rename listener instance Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Description
This change adds logic to track failures at query group level for co-ordinator search requests.
Related Issues
Resolves #15120
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.