Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Introduce allocation filter to control placement of search only replicas #15702

Merged
merged 3 commits into from
Sep 5, 2024
Merged

[Backport 2.x] Introduce allocation filter to control placement of search only replicas #15702

merged 3 commits into from
Sep 5, 2024

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Sep 4, 2024

This is a manual backport of #15455 to 2.x.

2.x line throws a different exception type for validation errors while creating an index (IAE vs SettingsException). This updates the backported tests to the expected type.

@mch2
[RW Separation] Introduce allocation filter to control placement of s…
d48f926 
…earch only replicas (opensearch-project#15455)

* Introduce allocation filter to control placement of search only replicas

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Add a new decider rather than updating the existing FilterAllocationDecider

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Fix license header and description on SearchReplicaAllocationDecider

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Pr feedback.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Fix class name to pass precommit checks

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Refactor all search replica create/update tests to a single OpenSearchSingleNodeTestCase.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* remove changelog entry

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

---------

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
@mch2
update exception types for 2.x
7d79de3 
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 7d79de3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 7d79de3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mch2
Merge remote-tracking branch 'upstream/2.x' into 2.x
2ba2e2c 
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 7d79de3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 2ba2e2c: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.70%. Comparing base (017f7d4) to head (2ba2e2c).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...cation/decider/SearchReplicaAllocationDecider.java 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #15702      +/-   ##
============================================
- Coverage     71.72%   71.70%   -0.03%     
- Complexity    64329    64356      +27     
============================================
  Files          5261     5262       +1     
  Lines        300936   300959      +23     
  Branches      43822    43825       +3     
============================================
- Hits         215854   215799      -55     
- Misses        67024    67143     +119     
+ Partials      18058    18017      -41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mch2 mch2 merged commit b44242d into opensearch-project:2.x Sep 5, 2024
35 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
@github-actions
[Backport 2.x] Introduce allocation filter to control placement of se…
8027256 
…arch only replicas (#15702)

(cherry picked from commit b44242d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 5, 2024
Merged
msfroh pushed a commit that referenced this pull request Sep 5, 2024
@opensearch-trigger-bot
[Backport 2.x] Introduce allocation filter to control placement of se…
fbe8497 
…arch only replicas (#15702) (#15711)
This was referenced Sep 6, 2024
Open
Open
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.17 skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mch2 @andrross