Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix escaped wildcard query on wildcard field #15737

Merged
merged 4 commits into from
Sep 10, 2024
Merged

fix escaped wildcard query on wildcard field #15737

merged 4 commits into from
Sep 10, 2024

Conversation

HUSTERGS
Copy link
Contributor

@HUSTERGS HUSTERGS commented Sep 5, 2024

Description

fix escaped wildcard query on wildcard field

Related Issues

Resolves #15555

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working Search Search query, autocomplete ...etc labels Sep 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for b5c8df2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@HUSTERGS HUSTERGS force-pushed the fix_escaped_wildcard_field_query branch from b5c8df2 to 747de82 Compare September 5, 2024 07:14
@HUSTERGS HUSTERGS force-pushed the fix_escaped_wildcard_field_query branch from 747de82 to 76bb83b Compare September 5, 2024 07:16
@HUSTERGS HUSTERGS mentioned this pull request Sep 5, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 747de82: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 76bb83b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 63a87c0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@HUSTERGS HUSTERGS force-pushed the fix_escaped_wildcard_field_query branch from 63a87c0 to fbcd5de Compare September 5, 2024 16:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for fbcd5de: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.96774% with 9 lines in your changes missing coverage. Please review.

Project coverage is 71.77%. Comparing base (7cb2bd0) to head (11d0e91).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...g/opensearch/index/mapper/WildcardFieldMapper.java 70.96% 2 Missing and 7 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #15737      +/-   ##
============================================
- Coverage     71.85%   71.77%   -0.08%     
+ Complexity    64213    64142      -71     
============================================
  Files          5272     5272              
  Lines        300538   300557      +19     
  Branches      43432    43440       +8     
============================================
- Hits         215947   215736     -211     
- Misses        66833    67090     +257     
+ Partials      17758    17731      -27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gesong.samuel added 3 commits September 9, 2024 15:35
fix escaped wildcard query on wildcard field
d730628 
Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>
fix format error
dfc317b 
Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>
add change log
1d9765c 
Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>
@HUSTERGS HUSTERGS force-pushed the fix_escaped_wildcard_field_query branch from 63d67ab to 1d9765c Compare September 9, 2024 07:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

❌ Gradle check result for 63d67ab: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

❕ Gradle check result for 1d9765c: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@msfroh
Copy link
Collaborator

msfroh commented Sep 9, 2024

This change looks great, @HUSTERGS -- Thanks a lot for fixing this!

@msfroh
Merge branch 'main' into fix_escaped_wildcard_field_query
11d0e91 
Signed-off-by: Michael Froh <froh@amazon.com>
@msfroh msfroh added the backport 2.x Backport to 2.x branch label Sep 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

✅ Gradle check result for 11d0e91: SUCCESS

@HUSTERGS
Copy link
Contributor Author

It seems this PR is hanging forever with Minimum approval count Expected — Waiting for status to be reported, is there anything I can do? @msfroh

@msfroh
Copy link
Collaborator

msfroh commented Sep 10, 2024

It seems this PR is hanging forever with Minimum approval count Expected — Waiting for status to be reported, is there anything I can do? @msfroh

Sorry -- that's on me. I resolved conflicts on the changelog, but I need to approve it again (since my changelog update is "not approved").

@msfroh msfroh merged commit 320611a into opensearch-project:main Sep 10, 2024
35 of 38 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 10, 2024
@github-actions @msfroh
fix escaped wildcard query on wildcard field (#15737)
7477bdf 
* fix escaped wildcard query on wildcard field

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

* fix format error

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

* add change log

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

---------

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>
Signed-off-by: Michael Froh <froh@amazon.com>
Co-authored-by: gesong.samuel <gesong.samuel@bytedance.com>
Co-authored-by: Michael Froh <froh@amazon.com>
(cherry picked from commit 320611a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 10, 2024
Merged
msfroh added a commit that referenced this pull request Sep 10, 2024
@opensearch-trigger-bot @github-actions @msfroh
fix escaped wildcard query on wildcard field (#15737) (#15892)
b4f85a0 
* fix escaped wildcard query on wildcard field
* fix format error
* add change log

---------

(cherry picked from commit 320611a)

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>
Signed-off-by: Michael Froh <froh@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: gesong.samuel <gesong.samuel@bytedance.com>
Co-authored-by: Michael Froh <froh@amazon.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 9, 2024
Open
@hasnain2808 hasnain2808 mentioned this pull request Sep 16, 2024
Closed
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
@HUSTERGS @msfroh @dk2k
fix escaped wildcard query on wildcard field (opensearch-project#15737)
dee2040 
* fix escaped wildcard query on wildcard field

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

* fix format error

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

* add change log

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

---------

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>
Signed-off-by: Michael Froh <froh@amazon.com>
Co-authored-by: gesong.samuel <gesong.samuel@bytedance.com>
Co-authored-by: Michael Froh <froh@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
@HUSTERGS @msfroh @dk2k
fix escaped wildcard query on wildcard field (opensearch-project#15737)
39d69c9 
* fix escaped wildcard query on wildcard field

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

* fix format error

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

* add change log

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

---------

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>
Signed-off-by: Michael Froh <froh@amazon.com>
Co-authored-by: gesong.samuel <gesong.samuel@bytedance.com>
Co-authored-by: Michael Froh <froh@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
@HUSTERGS @msfroh @dk2k
fix escaped wildcard query on wildcard field (opensearch-project#15737)
f341a0c 
* fix escaped wildcard query on wildcard field

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

* fix format error

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

* add change log

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

---------

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>
Signed-off-by: Michael Froh <froh@amazon.com>
Co-authored-by: gesong.samuel <gesong.samuel@bytedance.com>
Co-authored-by: Michael Froh <froh@amazon.com>
@BrewTestBot BrewTestBot mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfroh msfroh msfroh approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Search Search query, autocomplete ...etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Escaped wildcard character in wildcard query not handled correctly
2 participants
@HUSTERGS @msfroh