Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Integrate translog cleanup with snapshot deletion and fix primary term deletion logic #15742

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7b0846e from #15657.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 0ac8b84: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 0ac8b84: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…m deletion logic (#15657)

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
(cherry picked from commit 7b0846e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Sep 9, 2024

✅ Gradle check result for 331bb48: SUCCESS

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 40.62500% with 76 lines in your changes missing coverage. Please review.

Project coverage is 71.67%. Comparing base (19c204f) to head (331bb48).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...index/translog/RemoteFsTimestampAwareTranslog.java 40.00% 44 Missing and 1 partial ⚠️
...ch/repositories/blobstore/BlobStoreRepository.java 0.00% 19 Missing ⚠️
...ex/translog/transfer/TranslogTransferMetadata.java 67.85% 6 Missing and 3 partials ⚠️
...dex/translog/transfer/TranslogTransferManager.java 50.00% 1 Missing and 1 partial ⚠️
...ndex/store/RemoteSegmentStoreDirectoryFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15742      +/-   ##
============================================
- Coverage     71.68%   71.67%   -0.01%     
+ Complexity    64487    64472      -15     
============================================
  Files          5263     5263              
  Lines        301684   301795     +111     
  Branches      43927    43940      +13     
============================================
+ Hits         216271   216323      +52     
- Misses        67311    67388      +77     
+ Partials      18102    18084      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale merged commit 8a119fa into 2.x Sep 9, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant