Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the capability to override indices.breaker.total.use_real_memory setting for test clusters #15906

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

navneet1v
Copy link
Contributor

@navneet1v navneet1v commented Sep 11, 2024

Description

Add the capability to override indices.breaker.total.use_real_memory setting for test clusters.

This will allow plugins to run the integTest with heap CB enabled to ensure that their integTests runs with as close of a env which we have in Jenkins. Please read the attached issue for more details

Testing

Validated that setting can be override like this:

./gradlew :integTest -Dtests.opensearch.indices.breaker.total.use_real_memory=true

Related Issues

Resolves #15849

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. enhancement Enhancement or improvement to existing feature or request labels Sep 11, 2024
@navneet1v navneet1v added skip-changelog backport 2.x Backport to 2.x branch labels Sep 11, 2024
Copy link
Contributor

❌ Gradle check result for 9c63bc4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…setting for test clusters

Signed-off-by: Navneet Verma <navneev@amazon.com>
Copy link
Contributor

❕ Gradle check result for 32d6d5c: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.96%. Comparing base (92d7fe8) to head (32d6d5c).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...opensearch/gradle/testclusters/OpenSearchNode.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15906      +/-   ##
============================================
+ Coverage     71.90%   71.96%   +0.05%     
- Complexity    64216    64280      +64     
============================================
  Files          5272     5277       +5     
  Lines        300597   300691      +94     
  Branches      43440    43449       +9     
============================================
+ Hits         216151   216378     +227     
+ Misses        66680    66589      -91     
+ Partials      17766    17724      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@navneet1v
Copy link
Contributor Author

@msfroh, @reta can I get a review on this code?

Copy link
Collaborator

@msfroh msfroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... Makes sense.

Do you know if there are any other important settings that differ between the Jenkins tests (or a typical production system) and the integ tests? Anything else where we might be missing out?

@navneet1v
Copy link
Contributor Author

navneet1v commented Sep 13, 2024

Yeah... Makes sense.

Do you know if there are any other important settings that differ between the Jenkins tests (or a typical production system) and the integ tests? Anything else where we might be missing out?

If we look at the baseconfig in the diff file these are the only settings which are different from jenkins because these are what set by testcluster gradle task. I didn’t find any other setting more useful.

@reta reta merged commit 07029b2 into opensearch-project:main Sep 13, 2024
34 of 35 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 13, 2024
…setting for test clusters (#15906)

Signed-off-by: Navneet Verma <navneev@amazon.com>
(cherry picked from commit 07029b2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Sep 13, 2024
…setting for test clusters (#15906) (#15930)

(cherry picked from commit 07029b2)

Signed-off-by: Navneet Verma <navneev@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit to sachinpkale/OpenSearch that referenced this pull request Sep 19, 2024
…setting for test clusters (opensearch-project#15906)

Signed-off-by: Navneet Verma <navneev@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
…setting for test clusters (opensearch-project#15906)

Signed-off-by: Navneet Verma <navneev@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
…setting for test clusters (opensearch-project#15906)

Signed-off-by: Navneet Verma <navneev@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
…setting for test clusters (opensearch-project#15906)

Signed-off-by: Navneet Verma <navneev@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. enhancement Enhancement or improvement to existing feature or request skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow indices.breaker.total.use_real_memory to be updated in Test clusters
3 participants