Implement WithFieldName interface in ValuesSourceAggregationBuilder & FieldSortBuilder #15916

dzane17 · 2024-09-12T17:15:41Z

Description

Implement WithFieldName interface in ValuesSourceAggregationBuilder & FieldSortBuilder

This is a continuation of #15705

Related Issues

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2024-09-12T17:36:06Z

❌ Gradle check result for 89f2845: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-09-12T18:37:52Z

❕ Gradle check result for 95fff6b: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2024-09-12T18:38:26Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.87%. Comparing base (c709400) to head (ca04f8c).
Report is 6 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #15916      +/-   ##
============================================
- Coverage     71.93%   71.87%   -0.06%     
+ Complexity    64374    64305      -69     
============================================
  Files          5277     5277              
  Lines        300828   300830       +2     
  Branches      43474    43474              
============================================
- Hits         216411   216233     -178     
- Misses        66725    66834     +109     
- Partials      17692    17763      +71

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-09-12T20:19:08Z

❕ Gradle check result for 57dbbd0: UNSTABLE

TEST FAILURES:

      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode
      1 org.opensearch.gateway.RecoveryFromGatewayIT.testReuseInFileBasedPeerRecovery
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions · 2024-09-12T20:26:04Z

❌ Gradle check result for 090247f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-09-16T20:10:30Z

❌ Gradle check result for ca04f8c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

jainankitk · 2024-09-16T20:30:25Z

❌ Gradle check result for ca04f8c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Unrelated flaky test:

[Test Result](https://build.ci.opensearch.org/job/gradle-check/47888/testReport/) (1 failure / -1)

    [org.opensearch.telemetry.metrics.TelemetryMetricsEnabledSanityIT.testGauge](https://build.ci.opensearch.org/job/gradle-check/47888/testReport/junit/org.opensearch.telemetry.metrics/TelemetryMetricsEnabledSanityIT/testGauge/)

jainankitk · 2024-09-16T20:34:20Z

Related to #15953

github-actions · 2024-09-16T22:34:26Z

❌ Gradle check result for ca04f8c: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

jainankitk · 2024-09-16T23:24:59Z

❌ Gradle check result for ca04f8c: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

More flaky tests:

[Test Result](https://build.ci.opensearch.org/job/gradle-check/47890/testReport/) (2 failures / +1)

    [org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimaryMultipleReplicaShards](https://build.ci.opensearch.org/job/gradle-check/47890/testReport/junit/org.opensearch.remotestore/RemoteStoreStatsIT/testDownloadStatsCorrectnessSinglePrimaryMultipleReplicaShards/)
    [org.opensearch.index.IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex](https://build.ci.opensearch.org/job/gradle-check/47890/testReport/junit/org.opensearch.index/IndexServiceTests/testAsyncTranslogTrimTaskOnClosedIndex/)

jainankitk · 2024-09-16T23:42:52Z

Related to #14310

jainankitk · 2024-09-16T23:44:04Z

Related to #14407

github-actions · 2024-09-17T00:18:09Z

❌ Gradle check result for ca04f8c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

jainankitk · 2024-09-17T00:58:22Z

❌ Gradle check result for ca04f8c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Seems the failing tests were fixed as part of #15859:

[Test Result](https://build.ci.opensearch.org/job/gradle-check/47894/testReport/) (2 failures / +1)

    [org.opensearch.rest.ReactorNetty4StreamingStressIT.testCloseClientStreamingRequest](https://build.ci.opensearch.org/job/gradle-check/47894/testReport/junit/org.opensearch.rest/ReactorNetty4StreamingStressIT/testCloseClientStreamingRequest/)
    [org.opensearch.rest.ReactorNetty4StreamingStressIT.classMethod](https://build.ci.opensearch.org/job/gradle-check/47894/testReport/junit/org.opensearch.rest/ReactorNetty4StreamingStressIT/classMethod/)

@dzane17 - Can you merge from latest main branch?

github-actions · 2024-09-17T06:39:51Z

❌ Gradle check result for ca04f8c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

dzane17 · 2024-09-17T16:27:11Z

@jainankitk The branch is up to date including that flaky test PR 15859

github-actions · 2024-09-17T19:15:48Z

❕ Gradle check result for ca04f8c: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

opensearch-trigger-bot · 2024-09-17T22:29:58Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15916-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7c427d9fd588597343654d2f534952f7116d1df4
# Push it to GitHub
git push --set-upstream origin backport/backport-15916-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15916-to-2.x.

… FieldSortBuilder (opensearch-project#15916) Signed-off-by: David Zane <davizane@amazon.com> (cherry picked from commit 7c427d9)

… FieldSortBuilder (opensearch-project#15916) Signed-off-by: David Zane <davizane@amazon.com>

… FieldSortBuilder (opensearch-project#15916) Signed-off-by: David Zane <davizane@amazon.com> (cherry picked from commit 7c427d9)

… FieldSortBuilder (#15916) (#15970) Signed-off-by: David Zane <davizane@amazon.com> (cherry picked from commit 7c427d9)

… FieldSortBuilder (opensearch-project#15916) Signed-off-by: David Zane <davizane@amazon.com>

dzane17 force-pushed the with-field-name branch from 89f2845 to 95fff6b Compare September 12, 2024 17:34

dzane17 force-pushed the with-field-name branch from 95fff6b to 57dbbd0 Compare September 12, 2024 19:17

dzane17 changed the title ~~Implement WithFieldName interface in ValuesSourceAggregationBuilder~~ Implement WithFieldName interface in ValuesSourceAggregationBuilder & FieldSortBuilder Sep 12, 2024

dzane17 force-pushed the with-field-name branch from 57dbbd0 to 090247f Compare September 12, 2024 19:30

dzane17 added the backport 2.x Backport to 2.x branch label Sep 12, 2024

jainankitk marked this pull request as ready for review September 12, 2024 20:59

jainankitk requested review from anasalkouz, andrross, ashking94, Bukhtawar, CEHENKLE, dblock, dbwiddis, gbbafna, jed326, kotwanikunal, mch2, msfroh, nknize, owaiskazi19, reta, Rishikesh1159, sachinpkale, saratvemulapalli and shwetathareja as code owners September 12, 2024 20:59

jainankitk approved these changes Sep 17, 2024

View reviewed changes

jainankitk merged commit 7c427d9 into opensearch-project:main Sep 17, 2024
34 checks passed

dzane17 deleted the with-field-name branch September 17, 2024 22:29

opensearch-trigger-bot bot added the backport-failed label Sep 17, 2024

opensearch-ci-bot mentioned this pull request Sep 18, 2024

[AUTOCUT] Gradle Check Flaky Test Report for MoreExpressionIT #15823

Open

dzane17 mentioned this pull request Sep 18, 2024

[Backport 2.x] Implement WithFieldName interface in ValuesSourceAggregationBuilder & FieldSortBuilder #15970

Merged

3 tasks

opensearch-ci-bot mentioned this pull request Sep 18, 2024

[AUTOCUT] Gradle Check Flaky Test Report for IndexServiceTests #14407

Open

sachinpkale pushed a commit to sachinpkale/OpenSearch that referenced this pull request Sep 19, 2024

Implement WithFieldName interface in ValuesSourceAggregationBuilder &…

d4ecbc7

… FieldSortBuilder (opensearch-project#15916) Signed-off-by: David Zane <davizane@amazon.com>

jainankitk pushed a commit that referenced this pull request Sep 19, 2024

Implement WithFieldName interface in ValuesSourceAggregationBuilder &…

dd5c31b

… FieldSortBuilder (#15916) (#15970) Signed-off-by: David Zane <davizane@amazon.com> (cherry picked from commit 7c427d9)

opensearch-ci-bot mentioned this pull request Sep 24, 2024

[AUTOCUT] Gradle Check Flaky Test Report for SearchTimeoutIT #16056

Open

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024

Implement WithFieldName interface in ValuesSourceAggregationBuilder &…

a1be7f0

… FieldSortBuilder (opensearch-project#15916) Signed-off-by: David Zane <davizane@amazon.com>

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024

Implement WithFieldName interface in ValuesSourceAggregationBuilder &…

e7d62b4

… FieldSortBuilder (opensearch-project#15916) Signed-off-by: David Zane <davizane@amazon.com>

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024

Implement WithFieldName interface in ValuesSourceAggregationBuilder &…

c55fee3

… FieldSortBuilder (opensearch-project#15916) Signed-off-by: David Zane <davizane@amazon.com>

BrewTestBot mentioned this pull request Nov 6, 2024

opensearch 2.18.0 Homebrew/homebrew-core#196785

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement WithFieldName interface in ValuesSourceAggregationBuilder & FieldSortBuilder #15916

Implement WithFieldName interface in ValuesSourceAggregationBuilder & FieldSortBuilder #15916

dzane17 commented Sep 12, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024

github-actions bot commented Sep 12, 2024

codecov bot commented Sep 12, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024

github-actions bot commented Sep 12, 2024

github-actions bot commented Sep 16, 2024

jainankitk commented Sep 16, 2024

jainankitk commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

jainankitk commented Sep 16, 2024

jainankitk commented Sep 16, 2024

jainankitk commented Sep 16, 2024

github-actions bot commented Sep 17, 2024

jainankitk commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

dzane17 commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

opensearch-trigger-bot bot commented Sep 17, 2024

Implement WithFieldName interface in ValuesSourceAggregationBuilder & FieldSortBuilder #15916

Implement WithFieldName interface in ValuesSourceAggregationBuilder & FieldSortBuilder #15916

Conversation

dzane17 commented Sep 12, 2024 • edited Loading

Description

Related Issues

Check List

github-actions bot commented Sep 12, 2024

github-actions bot commented Sep 12, 2024

codecov bot commented Sep 12, 2024 • edited Loading

Codecov Report

github-actions bot commented Sep 12, 2024

github-actions bot commented Sep 12, 2024

github-actions bot commented Sep 16, 2024

jainankitk commented Sep 16, 2024

jainankitk commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

jainankitk commented Sep 16, 2024

jainankitk commented Sep 16, 2024

jainankitk commented Sep 16, 2024

github-actions bot commented Sep 17, 2024

jainankitk commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

dzane17 commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

opensearch-trigger-bot bot commented Sep 17, 2024

dzane17 commented Sep 12, 2024 •

edited

Loading

codecov bot commented Sep 12, 2024 •

edited

Loading