Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add validation for the search backpressure cancellation settings #15969

Merged
merged 3 commits into from
Sep 19, 2024
Merged

[Backport 2.x] Add validation for the search backpressure cancellation settings #15969

merged 3 commits into from
Sep 19, 2024

Conversation

gaobinlong
Copy link
Collaborator

Description

Backport #15501 to 2.x

Related Issues

#15495

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaobinlong
Add validation for the search backpressure cancellation settings (ope…
1e59f38 
…nsearch-project#15501)

* Fix updating search backpressure settings crashing the cluster

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Modify change log

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Fix version check

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Increase test coverage

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Format the code

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Optimize some code

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Fix typo

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
(cherry picked from commit 8347d0e)
@gaobinlong
Update version check in yml test file
c97fcc4 
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 1e59f38: SUCCESS

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for c97fcc4: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.75000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.76%. Comparing base (bfdc30c) to head (34e958a).
Report is 8 commits behind head on 2.x.

Files with missing lines Patch % Lines
...kpressure/settings/SearchBackpressureSettings.java 25.00% 3 Missing and 3 partials ⚠️
...backpressure/settings/SearchShardTaskSettings.java 75.00% 1 Missing and 1 partial ⚠️
...arch/backpressure/settings/SearchTaskSettings.java 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #15969      +/-   ##
============================================
+ Coverage     71.67%   71.76%   +0.08%     
- Complexity    64624    64705      +81     
============================================
  Files          5276     5276              
  Lines        302298   302332      +34     
  Branches      43992    43995       +3     
============================================
+ Hits         216674   216961     +287     
+ Misses        67532    67232     -300     
- Partials      18092    18139      +47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaobinlong
Copy link
Collaborator Author

Hi @reta, do you know how to fix the failure of detect breaking changes check? The report shows a new public method is added(in this PR), and a public method is removed(by another PR).
image

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 18, 2024
Open
@reta
Copy link
Collaborator

reta commented Sep 18, 2024

Hi @reta, do you know how to fix the failure of detect breaking changes check? The report shows a new public method is added(in this PR), and a public method is removed(by another PR).

Thanks @gaobinlong , fix is raised #15980

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 34e958a: SUCCESS

@reta reta merged commit af25ece into opensearch-project:2.x Sep 19, 2024
33 of 35 checks passed
@reta reta mentioned this pull request Sep 19, 2024
Merged
This was referenced Sep 19, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@UglyJoevIne UglyJoevIne UglyJoevIne approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaobinlong @reta @UglyJoevIne