-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[S3 Repository] Change default retry mechanism of s3 clients to Standard Mode #15978
[S3 Repository] Change default retry mechanism of s3 clients to Standard Mode #15978
Conversation
❌ Gradle check result for 5c32ca5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
5c32ca5
to
1dc8dc5
Compare
❌ Gradle check result for 1dc8dc5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
1dc8dc5
to
a11f678
Compare
❌ Gradle check result for a11f678: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
a11f678
to
f1e64a2
Compare
❌ Gradle check result for f1e64a2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
f1e64a2
to
234d09a
Compare
❌ Gradle check result for 234d09a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
234d09a
to
2bed915
Compare
❌ Gradle check result for 2bed915: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
2bed915
to
80e2812
Compare
❌ Gradle check result for 80e2812: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
80e2812
to
06c4008
Compare
❌ Gradle check result for 06c4008: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
06c4008
to
48403f2
Compare
❌ Gradle check result for 48403f2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
48403f2
to
8c23e59
Compare
❌ Gradle check result for 78cc4d4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
78cc4d4
to
73dc7a8
Compare
❌ Gradle check result for 73dc7a8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
73dc7a8
to
aeed476
Compare
❌ Gradle check result for aeed476: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
aeed476
to
33bf17f
Compare
❌ Gradle check result for 33bf17f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
26d7885
to
16d4ba4
Compare
❌ Gradle check result for 16d4ba4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
16d4ba4
to
7faed51
Compare
❕ Gradle check result for 7faed51: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Arpit-Bandejiya <abandeji@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15978-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 908fefeed32ce205e7b6128a5a344bbf333a5e62
# Push it to GitHub
git push --set-upstream origin backport/backport-15978-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…rch-project#15978) Signed-off-by: Arpit Bandejiya <abandeji@amazon.com> (cherry picked from commit 908fefe)
…rch-project#15978) Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
…rch-project#15978) Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
…rch-project#15978) Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Description
This PR change the Default Backoff Strategy to
Standard
fromLegacy
. More info about it here: https://docs.aws.amazon.com/sdkref/latest/guide/feature-retry-behavior.htmlRelated Issues
Resolves #15397
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.