Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[S3 Repository] Change default retry mechanism of s3 clients to Standard Mode #15978

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

Arpit-Bandejiya
Copy link
Contributor

@Arpit-Bandejiya Arpit-Bandejiya commented Sep 18, 2024

Description

This PR change the Default Backoff Strategy to Standard from Legacy . More info about it here: https://docs.aws.amazon.com/sdkref/latest/guide/feature-retry-behavior.html

Related Issues

Resolves #15397

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 5c32ca5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 1dc8dc5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for a11f678: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for f1e64a2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Arpit-Bandejiya Arpit-Bandejiya changed the title [draft]Add jitter for remote download calls [Draft]Add jitter for remote download calls Sep 19, 2024
Copy link
Contributor

❌ Gradle check result for 234d09a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 2bed915: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 80e2812: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 06c4008: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 48403f2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions github-actions bot added Cluster Manager ClusterManager:RemoteState enhancement Enhancement or improvement to existing feature or request v2.18.0 Issues and PRs related to version 2.18.0 labels Sep 23, 2024
@Arpit-Bandejiya Arpit-Bandejiya marked this pull request as ready for review September 23, 2024 10:36
Copy link
Contributor

❌ Gradle check result for 78cc4d4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 73dc7a8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for aeed476: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 33bf17f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Arpit-Bandejiya Arpit-Bandejiya force-pushed the download-jitter branch 2 times, most recently from 26d7885 to 16d4ba4 Compare September 30, 2024 17:12
Copy link
Contributor

❌ Gradle check result for 16d4ba4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Copy link
Contributor

github-actions bot commented Oct 1, 2024

❕ Gradle check result for 7faed51: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Signed-off-by: Arpit-Bandejiya <abandeji@amazon.com>
Copy link
Contributor

github-actions bot commented Oct 1, 2024

✅ Gradle check result for 540c429: SUCCESS

@gbbafna gbbafna merged commit 908fefe into opensearch-project:main Oct 1, 2024
32 of 34 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15978-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 908fefeed32ce205e7b6128a5a344bbf333a5e62
# Push it to GitHub
git push --set-upstream origin backport/backport-15978-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15978-to-2.x.

Arpit-Bandejiya added a commit to Arpit-Bandejiya/OpenSearch that referenced this pull request Oct 2, 2024
…rch-project#15978)

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

(cherry picked from commit 908fefe)
ashking94 pushed a commit that referenced this pull request Oct 2, 2024
…#16168)

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

(cherry picked from commit 908fefe)
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed Cluster Manager ClusterManager:RemoteState enhancement Enhancement or improvement to existing feature or request v2.18.0 Issues and PRs related to version 2.18.0
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Remote State] Add jitter to downloads from remote store
4 participants