Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] [Feature]Introduces ability to control access to and share resources #16030

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
+933 −2

Adds NamedWriteable implementations

37cacf0
Select commit
Loading
Failed to load commit list.
Draft

[DRAFT] [Feature]Introduces ability to control access to and share resources #16030

Adds NamedWriteable implementations
37cacf0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 27, 2024 in 0s

72.04% (target 70.00%)

View this Pull Request on Codecov

72.04% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 5.24017% with 217 lines in your changes missing coverage. Please review.

Project coverage is 72.04%. Comparing base (c82cd2e) to head (37cacf0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...earch/accesscontrol/resources/SharedWithScope.java 0.00% 78 Missing ⚠️
...earch/accesscontrol/resources/ResourceSharing.java 0.00% 68 Missing ⚠️
.../opensearch/accesscontrol/resources/ShareWith.java 0.00% 25 Missing ⚠️
.../opensearch/accesscontrol/resources/CreatedBy.java 0.00% 24 Missing ⚠️
...opensearch/accesscontrol/resources/EntityType.java 0.00% 8 Missing ⚠️
...earch/accesscontrol/resources/ResourceService.java 42.85% 7 Missing and 1 partial ⚠️
...earch/plugins/NoOpResourceAccessControlPlugin.java 14.28% 6 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #16030      +/-   ##
============================================
- Coverage     72.51%   72.04%   -0.48%     
+ Complexity    65562    65225     -337     
============================================
  Files          5318     5325       +7     
  Lines        303945   304173     +228     
  Branches      43976    44010      +34     
============================================
- Hits         220413   219143    -1270     
- Misses        65798    67082    +1284     
- Partials      17734    17948     +214

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov