-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop opensearch: Graceful close client connection #16091
Open
tmanninger
wants to merge
12
commits into
opensearch-project:main
Choose a base branch
from
tmanninger:grceful_shutdown
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
729284f
graceful shutdown
tmanninger 9621c15
fix typo in var
tmanninger f7b4ddd
spotless style
tmanninger 732d091
cleanup code
tmanninger 88b9aaf
Merge branch 'opensearch-project:main' into grceful_shutdown
tmanninger c7cb462
remove graceful stuff
tmanninger e0d8f08
Merge branch 'grceful_shutdown' of https://github.com/tmanninger/Open…
tmanninger 73c29d1
fix keep-alive connections
tmanninger ab55dbf
fix keep-alive connections
tmanninger d308955
fix keep-alive connections
tmanninger 65df2af
fix keep-alive connections
tmanninger d2c8c6a
fix keep-alive connections
tmanninger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @tmanninger , getting to it again just now. So I think this is what we want:
gracefulShutdownMillis
timeframeI believe we could make it part of the
RestChannel
(and leaveAbstractHttpServerTransport
out of it) by introducingRestChannel::closeGracefuly(long timeout)
method and calling it inCloseableChannel.closeChannels
(would need some adjustments).