Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump google-auth-library-oauth2-http from 1.7.0 to 1.29.0 in /plugins/repository-gcs #16520

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Bump google-auth-library-oauth2-http from 1.7.0 to 1.29.0 in /plugins/repository-gcs #16520

wants to merge 9 commits into from
+13 −9

Conversation

gaobinlong
Copy link
Collaborator

Description

google-auth-library-oauth2-http needs to be upgraded to 1.29.0 because the new version of com.google.cloud:google-cloud-core-http has a test dependency on it.

Related Issues

No issue.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaobinlong
Bump from 1.7.0 to 1.29.0 in /plugins/repository-gcs
902af7b 
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
@gaobinlong gaobinlong mentioned this pull request Oct 30, 2024
Open
@gaobinlong
Add change log
baef6b5 
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
@gaobinlong gaobinlong added the backport 2.x Backport to 2.x branch label Oct 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for baef6b5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gaobinlong
Merge branch 'main' into fix_version
472d53d 
Signed-off-by: gaobinlong <gbinlong@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 472d53d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 472d53d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Oct 30, 2024

Thanks @gaobinlong . we seems to have another pull request on the subject #16460, could you please help the contributor? Thank you!

@gaobinlong
merge main
00c7cf9 
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
@gaobinlong
Copy link
Collaborator Author

Thanks @gaobinlong . we seems to have another pull request on the subject #16460, could you please help the contributor? Thank you!

Sure, but that PR happens in the discover-gce plugin, this PR happens in repository-gcs, so may not conflict?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 00c7cf9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Oct 30, 2024 •
edited
Loading

Sure, but that PR happens in the discover-gce plugin, this PR happens in repository-gcs, so may not conflict?

Yes and no :) It seems like we are dealing with the same dependencies but plugins are different and versions are a bit messy, if you could help unify those, would be great (if it makes sense for sure). Thanks a lot!

@gaobinlong
move version to top-level file
b773a8b 
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b773a8b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b773a8b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b773a8b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gaobinlong
Fix build failure
0195c1d 
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 0195c1d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gaobinlong
Fix test failure
216eebe 
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 216eebe: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 216eebe: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 31, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 216eebe: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

✅ Gradle check result for 4bf2d4b: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.05%. Comparing base (0363aa7) to head (107347e).

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #16520      +/-   ##
============================================
+ Coverage     72.00%   72.05%   +0.04%     
- Complexity    65038    65062      +24     
============================================
  Files          5313     5313              
  Lines        303454   303454              
  Branches      43910    43910              
============================================
+ Hits         218510   218648     +138     
+ Misses        67040    66901     -139     
- Partials      17904    17905       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaobinlong
Revert some change
107347e 
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

✅ Gradle check result for 107347e: SUCCESS

reta
reta reviewed Nov 1, 2024
View reviewed changes
plugins/repository-gcs/build.gradle
/**
* Used for testing getting credentials from GCE
*/
test {
Copy link
Collaborator

@reta reta Nov 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gaobinlong , so tests are green but we need to think how the production deployment would look like. We may document that NO_GCE_CHECK environment variable is required to be set to true in order for a plugin to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta left review comments

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaobinlong @reta