Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.azure:azure-storage-common from 12.25.1 to 12.27.1 #16521

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

gaobinlong
Copy link
Collaborator

Description

com.azure:azure-storage-common needs to be upgraded from 12.25.1 to 12.27.1, because com.azure:azure-storage-blob:12.28.1 has a testing dependency on that version.

Related Issues

No issue.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
@gaobinlong gaobinlong added the backport 2.x Backport to 2.x branch label Oct 30, 2024
Copy link
Contributor

❌ Gradle check result for ac64b7d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for ac64b7d: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.11%. Comparing base (1e7c122) to head (ac64b7d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16521      +/-   ##
============================================
+ Coverage     72.03%   72.11%   +0.08%     
- Complexity    65038    65060      +22     
============================================
  Files          5313     5313              
  Lines        303442   303442              
  Branches      43910    43910              
============================================
+ Hits         218589   218841     +252     
+ Misses        66980    66652     -328     
- Partials      17873    17949      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit f57b889 into opensearch-project:main Oct 30, 2024
40 of 42 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16521-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f57b8895340341d79908401d8d27b427feaef2e9
# Push it to GitHub
git push --set-upstream origin backport/backport-16521-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-16521-to-2.x.

@reta
Copy link
Collaborator

reta commented Oct 30, 2024

@gaobinlong apologies, could you please backport to 2.x manually? thank you!

gaobinlong added a commit to gaobinlong/OpenSearch that referenced this pull request Oct 30, 2024
…ch-project#16521)

* Bump com.azure:azure-storage-common from 12.25.1 to 12.27.1

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Update changelog

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
reta pushed a commit that referenced this pull request Oct 30, 2024
…16525)

* Bump com.azure:azure-storage-common from 12.25.1 to 12.27.1



* Update changelog



---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants