Improve performance for resolving derived fields #16564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing the type check before the string comparison makes it much faster to resolve derived fields. Signed-off-by: Robson Araujo <robson.araujo@glean.com>
robson-glean
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
reta
added
backport 2.x
|
❕ Gradle check result for 83165ec: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
reta
approved these changes
Nov 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
Doing the type check before the string comparison makes it much faster to resolve derived fields. Signed-off-by: Robson Araujo <robson.araujo@glean.com> (cherry picked from commit e07499a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16564 +/- ##
============================================
- Coverage 72.00% 71.99% -0.02%
+ Complexity 65038 65030 -8
============================================
Files 5313 5313
Lines 303454 303469 +15
Branches 43910 43910
============================================
- Hits 218510 218471 -39
- Misses 67040 67100 +60
+ Partials 17904 17898 -6 ☔ View full report in Codecov by Sentry. |
reta
pushed a commit
that referenced
this pull request
Nov 5, 2024
Doing the type check before the string comparison makes it much faster to resolve derived fields. (cherry picked from commit e07499a) Signed-off-by: Robson Araujo <robson.araujo@glean.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Doing the type check before the string comparison makes it much faster to resolve derived fields.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.