Fix date hardcoding in date aggregator #17239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeshkr419
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
sandeshkr419
added
skip-changelog
bug
sandeshkr419
changed the title
owaiskazi19
approved these changes
Feb 3, 2025
|
❌ Gradle check result for 5277900: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
|
❕ Gradle check result for 786bb22: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17239 +/- ##
============================================
- Coverage 72.36% 71.32% -1.05%
+ Complexity 65733 64557 -1176
============================================
Files 5318 5318
Lines 305674 305676 +2
Branches 44349 44350 +1
============================================
- Hits 221197 218018 -3179
- Misses 66341 69496 +3155
- Partials 18136 18162 +26 ☔ View full report in Codecov by Sentry. |
msfroh
approved these changes
Feb 4, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
(cherry picked from commit b82ed5a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
(cherry picked from commit b82ed5a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
3 tasks
mch2
pushed a commit
that referenced
this pull request
Feb 4, 2025
mch2
pushed a commit
that referenced
this pull request
Feb 4, 2025
This was referenced Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix in date aggregator where date field was hard-coded. Fixed that to fetch from value-source if available.
This fix was included in #17165 but the PR is missed for 2.19 so creating a separate PR to only include the bug fix to be pushed to 2.19 branch as feature inclusion is blocked for now in 2.19
Will rebase #17165 after this PR gets merged.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Fix date field hard-coding introduced in #16674 - this is required to correctly fetch date field in Date Aggregation using star-tree
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.