-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remove] Type from Search Internals #2109
[Remove] Type from Search Internals #2109
Conversation
Can one of the admins verify this patch? |
❌ Gradle Check failure c58c6710a963b1af64d7db3cc86d2074e4a2543d |
❌ Gradle Check failure fc4bcc02fb282395b4dc431201a5f6f554ea2c78 |
fc4bcc0
to
46ea66b
Compare
✅ Gradle Check success 46ea66b94d2ff088d667818ef0ac7ce83b12fa34 |
@@ -153,18 +153,6 @@ public static IdsQueryBuilder idsQuery() { | |||
return new IdsQueryBuilder(); | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The public static TypeQueryBuilder typeQuery(String type)
should also be gone, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! not used anywhere. Removed
With types deprecation the type support is removed from internal search API (SearchRequest and QueryShardContext). Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
46ea66b
to
680c8b5
Compare
With types deprecation the type support is removed from internal search API
(
SearchRequest
andQueryShardContext
).relates #1940