Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remove] Type from Search Internals #2109

Merged
merged 4 commits into from
Feb 17, 2022

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Feb 15, 2022

With types deprecation the type support is removed from internal search API
(SearchRequest and QueryShardContext).

relates #1940

@nknize nknize added v2.0.0 Version 2.0.0 >breaking Identifies a breaking change. Indexing & Search labels Feb 15, 2022
@nknize nknize requested a review from a team as a code owner February 15, 2022 19:44
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@nknize nknize added the non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues label Feb 15, 2022
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure c58c6710a963b1af64d7db3cc86d2074e4a2543d
Log 2410

Reports 2410

@nknize nknize mentioned this pull request Feb 15, 2022
67 tasks
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure fc4bcc02fb282395b4dc431201a5f6f554ea2c78
Log 2414

Reports 2414

@nknize nknize force-pushed the remove/typeFromSearchInternals branch from fc4bcc0 to 46ea66b Compare February 15, 2022 21:01
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 46ea66b94d2ff088d667818ef0ac7ce83b12fa34
Log 2418

Reports 2418

@@ -153,18 +153,6 @@ public static IdsQueryBuilder idsQuery() {
return new IdsQueryBuilder();
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public static TypeQueryBuilder typeQuery(String type) should also be gone, right?

Copy link
Collaborator Author

@nknize nknize Feb 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! not used anywhere. Removed

With types deprecation the type support is removed from internal search API
(SearchRequest and QueryShardContext).

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize force-pushed the remove/typeFromSearchInternals branch from 46ea66b to 680c8b5 Compare February 17, 2022 21:17
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 680c8b5
Log 2522

Reports 2522

@nknize nknize merged commit 7fe642f into opensearch-project:main Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking Identifies a breaking change. Indexing & Search non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues v2.0.0 Version 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants