Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MapperService has to be passed in as null for EnginePlugins CodecService constructor #2177

Merged
merged 5 commits into from
Mar 8, 2022
Merged

MapperService has to be passed in as null for EnginePlugins CodecService constructor #2177

merged 5 commits into from
Mar 8, 2022

Commits on Mar 4, 2022

  1. MapperService has to be passed in as null for EnginePlugins CodecServ… 

    …ice constructor

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
    @reta
    reta committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    45665db View commit details
    Browse the repository at this point in the history

  2. Addressing code review comments 

    Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
    @reta
    reta committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    17c0abb View commit details
    Browse the repository at this point in the history

  3. Delayed CodecService instantiation up to the shard initialization 

    Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
    @reta
    reta committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    5c136be View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. Added logger (associated with shard) to CodecServiceConfig 

    Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
    @reta
    reta committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    eeeab29 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Refactored the EngineConfigFactory / IndexShard instantiation of the … 

    …CodecService

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
    @reta
    reta committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    5379899 View commit details
    Browse the repository at this point in the history