Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remove] Type from TermsLookUp #2459

Merged
merged 2 commits into from
Mar 15, 2022
Merged

[Remove] Type from TermsLookUp #2459

merged 2 commits into from
Mar 15, 2022

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Mar 14, 2022 •
edited
Loading

Signed-off-by: Suraj Singh surajrider@gmail.com

Description

Remove types from TermsLookUp

Related #1940

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dreamer-89 dreamer-89 requested a review from a team as a code owner March 14, 2022 17:00
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@dreamer-89
[Remove] Type from TermsLookUp
3277089 
Signed-off-by: Suraj Singh <surajrider@gmail.com>
nknize
nknize approved these changes Mar 14, 2022
View reviewed changes
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM!

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure eb1570f6bc4011a804a2198b84c970a9d26c577c
Log 3347

Reports 3347

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 3277089
Log 3348

Reports 3348

@dreamer-89
Fix unit test failure
2c078bf 
Signed-off-by: Suraj Singh <surajrider@gmail.com>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 2c078bf
Log 3350

Reports 3350

@dreamer-89
Copy link
Member Author 

REPRODUCE WITH: ./gradlew ':qa:remote-clusters:integTest' --tests "org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks" -Dtests.seed=41114CF1B51242AC -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=nl-NL -Dtests.timezone=America/Shiprock -Druntime.java=17

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([41114CF1B51242AC:4667993A8E9434F1]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)

@dreamer-89
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 2c078bf
Log 3353

Reports 3353

@dreamer-89
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 2c078bf
Log 3374

Reports 3374

@dreamer-89 dreamer-89 merged commit 2b68b14 into opensearch-project:main Mar 15, 2022
@dreamer-89 dreamer-89 added v2.0.0 Version 2.0.0 non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >breaking Identifies a breaking change. Indexing & Search labels Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@nknize nknize nknize approved these changes

Assignees
No one assigned
Labels
>breaking Identifies a breaking change. Indexing & Search non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dreamer-89 @opensearch-ci-bot @reta @nknize