Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace internal usages of 'master' terminology in server directory #2518

Closed

Conversation

tlfeng
Copy link
Collaborator

@tlfeng tlfeng commented Mar 19, 2022

Description

Replacement rules:

  • master -> cluster_manager or clusterManager (variable name) or cluster-manager (code comment)
  • Master -> ClusterManager

Issues Resolved

A part of #1548

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@tlfeng tlfeng added enhancement Enhancement or improvement to existing feature or request v2.0.0 Version 2.0.0 labels Mar 19, 2022
@tlfeng tlfeng requested a review from a team as a code owner March 19, 2022 07:32
@tlfeng tlfeng force-pushed the server-master-internal-replace branch 2 times, most recently from 7dbf60b to b08c5b0 Compare March 19, 2022 07:49
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 6813827c36dbe7ed66b5b5262e263438daca44e9
Log 3541

Reports 3541

Tianli Feng added 2 commits March 19, 2022 01:21
Signed-off-by: Tianli Feng <ftianli@amazon.com>
Signed-off-by: Tianli Feng <ftianli@amazon.com>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 7dbf60b245114a422be2097514b6fba8f21792cc
Log 3544

Reports 3544

…nal-replace

Signed-off-by: Tianli Feng <ftianli@amazon.com>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure b08c5b0e929a704fbd1f74f8d2a7f327d107b020
Log 3545

Reports 3545

@tlfeng tlfeng force-pushed the server-master-internal-replace branch from b08c5b0 to 74b3065 Compare March 19, 2022 08:31
@tlfeng tlfeng marked this pull request as draft March 19, 2022 08:41
@tlfeng
Copy link
Collaborator Author

tlfeng commented Mar 19, 2022

I will split the PR further by sub-directory to control the lines of code change. (One spit PR is #2519)

@tlfeng tlfeng closed this Mar 19, 2022
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 74b3065
Log 3547

Reports 3547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request v2.0.0 Version 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants