Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type removal] Remove deprecation warning on use of _type in doc scripts #2564

Merged
merged 1 commit into from
Mar 23, 2022
Merged

[Type removal] Remove deprecation warning on use of _type in doc scripts #2564

merged 1 commit into from
Mar 23, 2022

Conversation

dreamer-89
Copy link
Member

Signed-off-by: Suraj Singh surajrider@gmail.com

Description

Remove deprecation warning on use of _type in doc scripts

Related: #1940

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dreamer-89 dreamer-89 requested a review from a team as a code owner March 22, 2022 21:41
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 5c7c8282a0e75ffdfdff80aec3d30a2b452d0132
Log 3678

Reports 3678

@owaiskazi19
Copy link
Member

owaiskazi19 commented Mar 22, 2022 •
edited
Loading

@dreamer-89 can you run ./gradlew :server:spotlessApply to fix the formatting issues?

@dreamer-89
Copy link
Member Author

dreamer-89 commented Mar 22, 2022 •
edited
Loading

Thanks @owaiskazi19 for checking this. Updating PR

@dreamer-89
[Type removal] Remove deprecation warning on use of _type in doc scripts
fa5a78d 
Signed-off-by: Suraj Singh <surajrider@gmail.com>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure fa5a78d
Log 3680

Reports 3680

@dreamer-89
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success fa5a78d
Log 3683

Reports 3683

nknize
nknize approved these changes Mar 23, 2022
View reviewed changes
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nknize nknize added backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch v3.0.0 Issues and PRs related to version 3.0.0 and removed v2.0.0 Version 2.0.0 labels Mar 23, 2022
@nknize nknize merged commit c1d5491 into opensearch-project:main Mar 23, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 23, 2022
@dreamer-89 @github-actions
[Type removal] Remove deprecation warning on use of _type in doc scri…
edc0804 
…pts (#2564)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit c1d5491)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 23, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 23, 2022
@dreamer-89 @github-actions
[Type removal] Remove deprecation warning on use of _type in doc scri…
be1ad54 
…pts (#2564)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit c1d5491)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 23, 2022
Merged
nknize pushed a commit that referenced this pull request Mar 24, 2022
@dreamer-89 @nknize
[Type removal] Remove deprecation warning on use of _type in doc scri…
e949f65 
…pts (#2564)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit c1d5491)
nknize pushed a commit that referenced this pull request Mar 24, 2022
@dreamer-89 @nknize
[Type removal] Remove deprecation warning on use of _type in doc scri…
023a4db 
…pts (#2564)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit c1d5491)
CEHENKLE pushed a commit that referenced this pull request Mar 24, 2022
@opensearch-trigger-bot @dreamer-89
[Type removal] Remove deprecation warning on use of _type in doc scri…
ce58702 
…pts (#2564) (#2568)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit c1d5491)

Co-authored-by: Suraj Singh <79435743+dreamer-89@users.noreply.github.com>
nknize pushed a commit that referenced this pull request Mar 25, 2022
@opensearch-trigger-bot
[Type removal] Remove deprecation warning on use of _type in doc scri…
8db6e49 
…pts (#2564) (#2567)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit c1d5491)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nknize nknize nknize approved these changes

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch Indexing & Search v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dreamer-89 @opensearch-ci-bot @owaiskazi19 @nknize