Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix InboundDecoder version compat check #2570

Merged

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Mar 23, 2022

Change InboundDecoder ensureVersionCompatibility check for onOrAfter
V_2_0_0 instead of explicit 2.0 check. This way bug fix and minor
versions will correctly handshake in a mixed 1.x Cluster.

Change InboundDecoder ensureVersionCompatibility check for onOrAfter
V_2_0_0 instead of explicit version check. This way bug fix and minor
versions will correctly handshake in a mixed 1.x Cluster.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize added bug Something isn't working v2.0.0 Version 2.0.0 pending backport Identifies an issue or PR that still needs to be backported backwards-compatibility labels Mar 23, 2022
@nknize nknize requested a review from a team as a code owner March 23, 2022 15:48
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure de18b21
Log 3701

Reports 3701

@nknize
Copy link
Collaborator Author

nknize commented Mar 23, 2022

#1561 failure; refiring.

@nknize
Copy link
Collaborator Author

nknize commented Mar 23, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure de18b21
Log 3702

Reports 3702

@nknize
Copy link
Collaborator Author

nknize commented Mar 23, 2022

#1703 failure; refiring

@nknize
Copy link
Collaborator Author

nknize commented Mar 23, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success de18b21
Log 3703

Reports 3703

@nknize nknize merged commit 511ac88 into opensearch-project:main Mar 23, 2022
@nknize nknize added backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch labels Mar 23, 2022
nknize added a commit that referenced this pull request Mar 23, 2022
Change InboundDecoder ensureVersionCompatibility check for onOrAfter
V_2_0_0 instead of explicit version check. This way bug fix and minor
versions will correctly handshake in a mixed 1.x Cluster.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 511ac88)
nknize added a commit that referenced this pull request Mar 23, 2022
Change InboundDecoder ensureVersionCompatibility check for onOrAfter
V_2_0_0 instead of explicit version check. This way bug fix and minor
versions will correctly handshake in a mixed 1.x Cluster.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 511ac88)
@nknize nknize removed the pending backport Identifies an issue or PR that still needs to be backported label Mar 23, 2022
nknize pushed a commit that referenced this pull request Mar 23, 2022
Change InboundDecoder ensureVersionCompatibility check for onOrAfter
V_2_0_0 instead of explicit version check. This way bug fix and minor
versions will correctly handshake in a mixed 1.x Cluster.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 511ac88)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch backwards-compatibility bug Something isn't working v2.0.0 Version 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants