Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PIT API #2745

Merged

Conversation

bharath-techie
Copy link
Contributor

@bharath-techie bharath-techie commented Apr 4, 2022

Description

This PR contains Create PIT API changes.
Context:
A Point In Time is a set of segments which are frozen in time taken at the moment of creation. We lock the segments of those indices’ shards and create contexts to access and query only those shards.
The Create PIT API returns PIT Id which later can be used as part of search requests to get results on that view of data.

Issues Resolved

#1147

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bharath-techie bharath-techie requested a review from a team as a code owner April 4, 2022 17:51
@bharath-techie bharath-techie changed the base branch from main to feature/point-in-time April 4, 2022 17:56
@bharath-techie bharath-techie changed the base branch from feature/point-in-time to main April 4, 2022 17:59
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 72bd39b
Log 4136

Reports 4136

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 72bd39b
Log 4139

Reports 4139

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 72bd39b
Log 4138

Reports 4138

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure edf18aceacd2e2c26c544e80331e7fc76344a3d1
Log 4140

Reports 4140

@dblock dblock requested a review from andrross April 5, 2022 00:19
@bharath-techie bharath-techie force-pushed the createpit branch 3 times, most recently from 120f5e3 to 960df6e Compare April 5, 2022 03:59
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 0e86d02a0b6aaedd572a8a9ee93fd666bd931e9a
Log 4176

Reports 4176

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 120f5e3a6e2a8811cc019ee17cc62d0d68ae1060
Log 4177

Reports 4177

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 960df6eefee951c2286e5e1bf0d1d62095d1e332
Log 4180

Reports 4180

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success efe2d0f25cdfc04701b649c302eaa9b2022dcc88
Log 4189

Reports 4189

@bharath-techie bharath-techie force-pushed the createpit branch 2 times, most recently from 1cd692a to 82a8020 Compare April 5, 2022 08:03
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 1cd692a798b5bac3a5302cdf17059ffc6e791fd5
Log 4192

Reports 4192

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 82a8020552cbc55f495d18151ba5c574c147fd0d
Log 4193

Reports 4193

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 751c320
Log 4194

Reports 4194

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success eba05e5
Log 4247

Reports 4247

@dblock dblock requested review from nknize and kartg April 6, 2022 14:40
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 471a64a
Log 5393

Reports 5393

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 47bb3e7
Log 5394

Reports 5394

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 3a20af0495fbae22c4ade96132d3e88bfbbf1780
Log 5396

Reports 5396

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success c28762e
Log 5397

Reports 5397

@bharath-techie bharath-techie changed the base branch from main to feature/point_in_time May 17, 2022 09:43
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success c28762e
Log 5398

Reports 5398

@Bukhtawar
Copy link
Collaborator

@bharath-techie can we fix up the branch, the rebase seems to have screwed it up

@bharath-techie bharath-techie changed the base branch from feature/point_in_time to main May 17, 2022 11:23
@bharath-techie
Copy link
Contributor Author

@bharath-techie can we fix up the branch, the rebase seems to have screwed it up

@Bukhtawar we need to change the base to feature/point_in_time branch before merge. It'll have a big diff as the diff will be against PIT changes + main.. i've changed it back to main , please change it to point in time feature branch before merge.

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success c28762e
Log 5399

Reports 5399

@Bukhtawar Bukhtawar requested a review from nknize May 17, 2022 14:10
@bharath-techie bharath-techie changed the base branch from main to feature/point_in_time May 18, 2022 15:47
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success f272405
Log 5424

Reports 5424

@Bukhtawar
Copy link
Collaborator

@reta @andrross @kartg Are you folks good with this?

@andrross
Copy link
Member

@Bukhtawar I see this is set to merge to the feature branch. What is the plan for getting this into main?

@reta
Copy link
Collaborator

reta commented May 18, 2022

@Bukhtawar I see this is set to merge to the feature branch. What is the plan for getting this into main?

The changeset is huge, could we rebase / merge feature branch with main first please? It is difficult to revisit the change, thanks!

@Bukhtawar
Copy link
Collaborator

@reta rebase is done
@andrross Yes we need to ensure we don't expose an API for a feature in development, the next few PRs should add the other set of APIs. In the interim we can explore putting this feature behind a feature flag and pushing to main

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success f272405
Log 5438

Reports 5438

@Bukhtawar Bukhtawar merged commit 4a1cbd9 into opensearch-project:feature/point_in_time May 19, 2022
@bharath-techie bharath-techie mentioned this pull request May 19, 2022
5 tasks
bharath-techie added a commit to bharath-techie/OpenSearch that referenced this pull request Jul 12, 2022
* Create Point In Time API changes

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants