Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deprecation warning for API call 'GET _cat/master' in 'ExceptionIT' of mixed cluster BWC test #2767

Merged

Conversation

tlfeng
Copy link
Collaborator

@tlfeng tlfeng commented Apr 5, 2022

Description

  • Allow deprecation warning when calling GET _cat/master API in ExceptionIT class of mixed cluster BWC test

The test ExceptionIT.testOpensearchException() calls API GET _cat/master to log the cluster-manager node ID.
Since the REST API is deprecated in version 2.0 and RestClient used in the test treats warning as failure, the test breaks when running the BWC test against node version >=2.0

Note:
Mixed cluster BWC test will spin up 4 nodes with the specified old version, and upgrade 2 nodes to the current version to form a mixed version cluster.

Issues Resolved

Resolve #2759

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… of mixed cluster BWC test

Signed-off-by: Tianli Feng <ftianli@amazon.com>
@tlfeng tlfeng requested a review from a team as a code owner April 5, 2022 06:15
@tlfeng tlfeng added :test Adding or fixing a test v2.1.0 Issues and PRs related to version 2.1.0 v3.0.0 Issues and PRs related to version 3.0.0 backport 2.x Backport to 2.x branch labels Apr 5, 2022
@tlfeng tlfeng changed the title Allow deprecation warning for API call GET _cat/master in ExceptionIT of mixed cluster BWC test Allow deprecation warning for API call 'GET _cat/master' in 'ExceptionIT' of mixed cluster BWC test Apr 5, 2022
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success b3c0929
Log 4190

Reports 4190

@saratvemulapalli saratvemulapalli merged commit 2491557 into opensearch-project:main Apr 7, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2767-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 249155772b65681ba8e91d2356e3430f2236b6be
# Push it to GitHub
git push --set-upstream origin backport/backport-2767-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2767-to-2.x.

@tlfeng tlfeng deleted the replace-cat-master-in-bwc branch June 3, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch :test Adding or fixing a test v2.1.0 Issues and PRs related to version 2.1.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure v2.0.0#mixedClusterTest o.o.backwards.ExceptionIT caused by 'GET _cat/master' deprecation warning
4 participants