Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Type Removal] Remove TypeFieldMapper usage, remove support of _type in searches and from LeafFieldsLookup #3016

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

dreamer-89
Copy link
Member

Description

This change introduces following changes:

  1. Remove usages of TypeFieldMapper class. In order to keep changes limited, retained TypeFieldMapper class which is referred in multiple tests for storing nested paths. Once, [Remove] Type from nested fields using new metadata field mapper #3004 is merged; this class can be removed completely.
  2. Remove _type support in searches. Bug [BUG] _type value in field of exists query returns all records #2989
  3. Remove type handling in LeafFieldsLookup

Issues Resolved

#2989

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
@dreamer-89 dreamer-89 requested review from a team and reta as code owners April 20, 2022 22:54
@dreamer-89 dreamer-89 changed the title [Remove] TypeFieldMapper usage [Type Removal] Remove TypeFieldMapper usage, _type in searches and from LeafFieldsLookup Apr 20, 2022
@dreamer-89 dreamer-89 changed the title [Type Removal] Remove TypeFieldMapper usage, _type in searches and from LeafFieldsLookup [Type Removal] Remove TypeFieldMapper usage, remove support of _type in searches and from LeafFieldsLookup Apr 20, 2022
@dreamer-89 dreamer-89 self-assigned this Apr 20, 2022
@dreamer-89 dreamer-89 added bug Something isn't working >breaking Identifies a breaking change. backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch labels Apr 20, 2022
@dreamer-89
Copy link
Member Author

Getting issues with gradle on ubuntu machine. Tried stopping/starting gradle but it didn't help.

ubuntu@ip-172-31-33-23:~/OpenSearch$ ./gradlew start

> Configure project :qa:os
Cannot add task 'destructiveDistroTest.docker' as a task with that name already exists.
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.4.2
  OS Info               : Linux 5.13.0-1019-aws (amd64)
  Runtime JDK Version   : 17 (Eclipse Temurin JDK)
  Runtime java.home     : /home/ubuntu/sw/jdk-17.0.1+12
  Gradle JDK Version    : 17 (Eclipse Temurin JDK)
  Gradle java.home      : /home/ubuntu/sw/jdk-17.0.1+12
  Random Testing Seed   : 3B2F9F522B14152D
  In FIPS 140 mode      : false
=======================================

FAILURE: Build completed with 4 failures.

1: Task failed with an exception.
-----------
* What went wrong:
Gradle could not start your build.
> Cannot create service of type TaskExecuter using method ProjectExecutionServices.createTaskExecuter() as there is a problem with parameter #14 of type ReservedFileSystemLocationRegistry.
   > Cannot create service of type ReservedFileSystemLocationRegistry using method ProjectExecutionServices.createReservedFileLocationRegistry() as there is a problem with parameter #1 of type List<ReservedFileSystemLocation>.
      > Could not create service of type ExecutionHistoryStore using ExecutionGradleServices.createExecutionHistoryStore().
         > Cannot lock execution history cache (/home/ubuntu/OpenSearch/.gradle/7.4.2/executionHistory) as it has already been locked by this process.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
==============================================================================

@dreamer-89 dreamer-89 requested a review from nknize April 20, 2022 23:06
@dreamer-89
Copy link
Member Author

start gradle check

@dreamer-89 dreamer-89 added the v3.0.0 Issues and PRs related to version 3.0.0 label Apr 20, 2022
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success ccfbf09
Log 4657

Reports 4657

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success ccfbf09
Log 4658

Reports 4658

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! LGTM!

@CEHENKLE
Copy link
Member

Since we're about to cut rc-1, I'd like to hold on backporting this to 2.0. But really looking forward to getting it into 2.0!

@nknize
Copy link
Collaborator

nknize commented Apr 21, 2022

I'd like to hold on backporting this to 2.0.

++ We'll have the PR auto opened but block the merge to prevent it from going in prematurely.

@nknize nknize merged commit dbdee30 into opensearch-project:main Apr 21, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 21, 2022
…` in searches and from LeafFieldsLookup (#3016)

Removes TypeFieldMapper and _type support from searches

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit dbdee30)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 21, 2022
…` in searches and from LeafFieldsLookup (#3016)

Removes TypeFieldMapper and _type support from searches

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit dbdee30)
nknize pushed a commit that referenced this pull request Apr 21, 2022
…` in searches and from LeafFieldsLookup (#3016) (#3018)

Removes TypeFieldMapper and _type support from searches

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit dbdee30)
dreamer-89 added a commit to dreamer-89/OpenSearch that referenced this pull request May 6, 2022
…` in searches and from LeafFieldsLookup (opensearch-project#3016)

Removes TypeFieldMapper and _type support from searches

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit dbdee30)
dblock pushed a commit that referenced this pull request May 10, 2022
…` in searches and from LeafFieldsLookup (#3016) (#3236)

Removes TypeFieldMapper and _type support from searches

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit dbdee30)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch >breaking Identifies a breaking change. bug Something isn't working v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants