[Remove] MainResponse version override cluster setting #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSearch 2.0.0 no longer needs HLRC compatibility with legacy clients. This commit removes all logic to spoof the version as a legacy cluster. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize
added
bug
10 tasks
reta
approved these changes
Apr 21, 2022
dblock
approved these changes
Apr 21, 2022
dblock
requested changes
Apr 21, 2022
There was a problem hiding this comment.
@nknize Before we merge, care to please add a clear explanation in the PR description of why this is removed in 2.0 vs. 3.0 (#3023 (comment) and #3023 (comment) are confusing vs. what's being done here, so is it that making OpenSearch 2.0 compatible with ES 7.10 in this mode would be too much work given, for example the Lucene upgrade, or something else?).
saratvemulapalli
approved these changes
Apr 21, 2022
dblock
approved these changes
Apr 21, 2022
Bleh. The description should've been updated in the merge comment too so commit history matches... Since we missed it here let's make sure to get it in the 2.x / 2.0 backport PR. |
I amended the commit messages for both backport PRs. |
nknize
added a commit
that referenced
this pull request
Apr 21, 2022
With types removal OpenSearch 2.0.0 no longer supports HLRC compatibility with legacy clients. This commit removes all 1.x logic to spoof the version as a legacy cluster. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> (cherry picked from commit cf78065)
nknize
added a commit
that referenced
this pull request
Apr 21, 2022
With types removal OpenSearch 2.0.0 no longer supports HLRC compatibility with legacy clients. This commit removes all 1.x logic to spoof the version as a legacy cluster. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> (cherry picked from commit cf78065)
nknize
added a commit
that referenced
this pull request
Apr 21, 2022
With types removal OpenSearch 2.0.0 no longer supports HLRC compatibility with legacy clients. This commit removes all 1.x logic to spoof the version as a legacy cluster. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> (cherry picked from commit cf78065) Co-authored-by: Nick Knize <nknize@apache.org>
nknize
pushed a commit
that referenced
this pull request
Apr 21, 2022
With types removal OpenSearch 2.0.0 no longer supports HLRC compatibility with legacy clients. This commit removes all 1.x logic to spoof the version as a legacy cluster. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> (cherry picked from commit cf78065)
nknize
added a commit
to nknize/OpenSearch
that referenced
this pull request
Jun 7, 2022
…earch-project#3031) (opensearch-project#3032)" This reverts commit 199fbb8. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize
added a commit
that referenced
this pull request
Jun 8, 2022
nknize
added a commit
that referenced
this pull request
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With types removal OpenSearch 2.0.0 no longer supports HLRC compatibility with legacy clients.
This commit removes all 1.x logic to spoof the version as a legacy cluster.
closes #3023