Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync maintainers with actual permissions. #3127

Merged
merged 1 commit into from
May 2, 2022

Conversation

dblock
Copy link
Member

@dblock dblock commented May 2, 2022

Signed-off-by: dblock dblock@amazon.com

Description

Fixing some discrepancies between names in this list and actual permissions that were introduced prior to us adding the external maintainers process.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock requested a review from CEHENKLE May 2, 2022 14:43
@dblock dblock requested review from a team and reta as code owners May 2, 2022 14:43
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success a7d469f
Log 4903

Reports 4903

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@nknize nknize merged commit e12b6b7 into opensearch-project:main May 2, 2022
@nknize nknize added documentation Improvements or additions to documentation non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues backport 2.x Backport to 2.x branch labels May 2, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3127-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e12b6b75f41abe3dd52efce321a4407d0c50967f
# Push it to GitHub
git push --set-upstream origin backport/backport-3127-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3127-to-2.x.

dblock added a commit to dblock/OpenSearch that referenced this pull request May 2, 2022
saratvemulapalli pushed a commit that referenced this pull request May 2, 2022
Signed-off-by: dblock <dblock@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 2, 2022
Signed-off-by: dblock <dblock@amazon.com>
(cherry picked from commit c9eda7d)
dblock added a commit that referenced this pull request May 3, 2022
Signed-off-by: dblock <dblock@amazon.com>
(cherry picked from commit c9eda7d)

Co-authored-by: Daniel Doubrovkine (dB.) <dblock@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch documentation Improvements or additions to documentation non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants