Fix minimum index compatibility error message #3159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotwanikunal
approved these changes
May 3, 2022
saratvemulapalli
approved these changes
May 3, 2022
VachaShah
approved these changes
May 3, 2022
|
❌ Gradle Check failure 5b25e052a29a5744643f2e4dc85fe3c67c106307 |
reta
approved these changes
May 3, 2022
adnapibar
reviewed
May 3, 2022
server/src/main/java/org/opensearch/cluster/metadata/MetadataIndexUpgradeService.java
Show resolved
Hide resolved
This is a very simple fix that adds a special case for the backward compatibility message for OS 1.x/ES 7.x. This basically mirrors a special case already codified in [Version][1]. I think this is a reasonable fix because it allows the message to be quite verbose. It should also only need to exist on the 2.x branch of OpenSearch since it is a special case that will no longer exist in 3.x when the entire LegacyESVersion concept can be removed from the code base. [1]: https://github.com/opensearch-project/OpenSearch/blob/cb238aae616d6a0fd8f82e128a1f94c8e4e8b1f7/server/src/main/java/org/opensearch/Version.java#L398 Signed-off-by: Andrew Ross <andrross@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 3, 2022
This is a very simple fix that adds a special case for the backward compatibility message for OS 1.x/ES 7.x. This basically mirrors a special case already codified in [Version][1]. I think this is a reasonable fix because it allows the message to be quite verbose. It should also only need to exist on the 2.x branch of OpenSearch since it is a special case that will no longer exist in 3.x when the entire LegacyESVersion concept can be removed from the code base. [1]: https://github.com/opensearch-project/OpenSearch/blob/cb238aae616d6a0fd8f82e128a1f94c8e4e8b1f7/server/src/main/java/org/opensearch/Version.java#L398 Signed-off-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 300620e)
andrross
added a commit
that referenced
this pull request
May 3, 2022
This is a very simple fix that adds a special case for the backward compatibility message for OS 1.x/ES 7.x. This basically mirrors a special case already codified in [Version][1]. I think this is a reasonable fix because it allows the message to be quite verbose. It should also only need to exist on the 2.x branch of OpenSearch since it is a special case that will no longer exist in 3.x when the entire LegacyESVersion concept can be removed from the code base. [1]: https://github.com/opensearch-project/OpenSearch/blob/cb238aae616d6a0fd8f82e128a1f94c8e4e8b1f7/server/src/main/java/org/opensearch/Version.java#L398 Signed-off-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 300620e) Co-authored-by: Andrew Ross <andrross@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very simple fix that adds a special case for the backward
compatibility message for OS 1.x/ES 7.x. This basically mirrors a
special case already codified in Version. I think this is a
reasonable fix because it allows the message to be quite verbose. It
should also only need to exist on the 2.x branch of OpenSearch since it
is a special case that will no longer exist in 3.x when the entire
LegacyESVersion concept can be removed from the code base.
Signed-off-by: Andrew Ross andrross@amazon.com
Issues Resolved
closes #2936
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.