Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generated ANTLR lexer/parser to match runtime version #3297

Merged
merged 1 commit into from
May 13, 2022
Merged

Update generated ANTLR lexer/parser to match runtime version #3297

merged 1 commit into from
May 13, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented May 12, 2022 •
edited
Loading

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

The ANTLR runtime version was updated to 4.9.3 by dependabot [1] however the runtime checks have been left unchanged and fill the logs with warnings like:

[2022-05-12T11:59:22,540][WARN ][stderr                   ] [xxx] ANTLR Tool version 4.5.3 used for code generation does not match the current runtime version 4.9.3
[2022-05-12T11:59:22,565][WARN ][stderr                   ] [xxx] ANTLR Tool version 4.5.3 used for code generation does not match the current runtime version 4.9.3

Regenerated lexer and parser using:

./gradlew :modules:lang-painless:regenParser

[1] fb76361

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta added backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch labels May 12, 2022
@reta reta requested a review from a team as a code owner May 12, 2022 19:38
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 1a49befd536fffd6dfd49bfbfd500f67f14b63c1
Log 5261

Reports 5261

@reta
Update generated ANTLR lexer/parser to match runtime version
cc653b0 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta changed the title Update ANTLR metadata version to match runtime version Update generated ANTLR lexer/parser to match runtime version May 12, 2022
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success dfd95eee3860a7dcd56cbb104ac50552a6999f52
Log 5262

Reports 5262

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success cc653b0
Log 5263

Reports 5263

nknize
nknize approved these changes May 12, 2022
View reviewed changes
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phew! beefy change!

@reta
Copy link
Collaborator Author

reta commented May 13, 2022

phew! beefy change!

thanks @nknize , it is just regenerated using the updated ANTLR

@nknize nknize merged commit 065e3cb into opensearch-project:main May 13, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 13, 2022
@reta @github-actions
Update generated ANTLR lexer/parser to match runtime version (#3297)
e7d868f 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 065e3cb)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 13, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 13, 2022
@reta @github-actions
Update generated ANTLR lexer/parser to match runtime version (#3297)
988ddc4 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 065e3cb)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 13, 2022
Merged
nknize pushed a commit that referenced this pull request May 13, 2022
@opensearch-trigger-bot
Update generated ANTLR lexer/parser to match runtime version (#3297) (#…
38cfeee 
…3307)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 065e3cb)
nknize pushed a commit that referenced this pull request May 13, 2022
@opensearch-trigger-bot
Update generated ANTLR lexer/parser to match runtime version (#3297) (#…
9c3a894 
…3308)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 065e3cb)
@kotwanikunal kotwanikunal mentioned this pull request Jun 15, 2022
Closed
@reta reta mentioned this pull request Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nknize nknize nknize approved these changes

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reta @opensearch-ci-bot @nknize