Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typed end-points for bulk, search, index APIs #3524

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Jun 7, 2022

Signed-off-by: Suraj Singh surajrider@gmail.com

Description

As a follow up of #3505; add typed end-points for bulk, search, index APIs. This change simply consumes type param (if any) without passing it to corresponding request object.

Issues Resolved

#3484

Related

#3505
#3528

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dreamer-89 dreamer-89 requested review from a team and reta as code owners June 7, 2022 01:06
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success e7ca2828316dad6177d1d1b0c70c5eeb9d9307d7
Log 5813

Reports 5813

Signed-off-by: Suraj Singh <surajrider@gmail.com>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 0844a8c
Log 5814

Reports 5814

@dreamer-89
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 0844a8c
Log 5815

Reports 5815

@dreamer-89 dreamer-89 requested a review from nknize June 7, 2022 05:06
@dreamer-89 dreamer-89 changed the title [WIP] Add typed end-points for bulk, search, index APIs Add typed end-points for bulk, search, index APIs Jun 7, 2022
@nknize nknize added bug Something isn't working v2.0.0 Version 2.0.0 backwards-compatibility v2.1.0 Issues and PRs related to version 2.1.0 backport 2.0 Backport to 2.0 branch and removed v2.0.0 Version 2.0.0 labels Jun 7, 2022
@nknize nknize merged commit f48043b into opensearch-project:2.x Jun 7, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 7, 2022
Reverts the removal of the docType endpoints for bulk, search, and index REST API.
This enables bulk API bwc with external clients such as Beats and Logstash until a
formal REST Version API mechanism is available for OpenSearch core.

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit f48043b)
dreamer-89 added a commit that referenced this pull request Jun 7, 2022
… (#3528)

Reverts the removal of the typed endpoints for bulk, search, and index REST API.
This enables bulk API bwc with external clients such as Beats and Logstash until a
formal REST Version API mechanism is available for OpenSearch core.

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit f48043b)

Co-authored-by: Suraj Singh <surajrider@gmail.com>
dreamer-89 added a commit to dreamer-89/OpenSearch that referenced this pull request Jun 10, 2022
dreamer-89 added a commit to dreamer-89/OpenSearch that referenced this pull request Jun 10, 2022
nknize pushed a commit that referenced this pull request Jun 10, 2022
* Revert "Revert removal of typed end-points for bulk, search, index APIs (#3524) (#3528)"

This reverts commit fc8803f.

* Revert "[Type removal] Ignore _type field in bulk request (#3504)"

This reverts commit 5bd7236.

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize pushed a commit that referenced this pull request Jun 10, 2022
* Revert "Revert removal of typed end-points for bulk, search, index APIs (#3524)"

This reverts commit f48043b.

* Revert "[Type removal] Ignore _type field in bulk request (#3505)"

This reverts commit a93ff13.

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.0 Backport to 2.0 branch backwards-compatibility bug Something isn't working v2.1.0 Issues and PRs related to version 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants