-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typed end-points for bulk, search, index APIs #3524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Gradle Check success e7ca2828316dad6177d1d1b0c70c5eeb9d9307d7 |
Signed-off-by: Suraj Singh <surajrider@gmail.com>
dreamer-89
force-pushed
the
type_fix_beats
branch
from
June 7, 2022 03:43
e7ca282
to
0844a8c
Compare
start gradle check |
dreamer-89
changed the title
[WIP] Add typed end-points for bulk, search, index APIs
Add typed end-points for bulk, search, index APIs
Jun 7, 2022
nknize
approved these changes
Jun 7, 2022
nknize
added
bug
Something isn't working
v2.0.0
Version 2.0.0
backwards-compatibility
v2.1.0
Issues and PRs related to version 2.1.0
backport 2.0
Backport to 2.0 branch
and removed
v2.0.0
Version 2.0.0
labels
Jun 7, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 7, 2022
Reverts the removal of the docType endpoints for bulk, search, and index REST API. This enables bulk API bwc with external clients such as Beats and Logstash until a formal REST Version API mechanism is available for OpenSearch core. Signed-off-by: Suraj Singh <surajrider@gmail.com> (cherry picked from commit f48043b)
dreamer-89
added a commit
that referenced
this pull request
Jun 7, 2022
… (#3528) Reverts the removal of the typed endpoints for bulk, search, and index REST API. This enables bulk API bwc with external clients such as Beats and Logstash until a formal REST Version API mechanism is available for OpenSearch core. Signed-off-by: Suraj Singh <surajrider@gmail.com> (cherry picked from commit f48043b) Co-authored-by: Suraj Singh <surajrider@gmail.com>
dreamer-89
added a commit
to dreamer-89/OpenSearch
that referenced
this pull request
Jun 10, 2022
…Is (opensearch-project#3524) (opensearch-project#3528)" This reverts commit fc8803f.
dreamer-89
added a commit
to dreamer-89/OpenSearch
that referenced
this pull request
Jun 10, 2022
…Is (opensearch-project#3524)" This reverts commit f48043b.
nknize
pushed a commit
that referenced
this pull request
Jun 10, 2022
* Revert "Revert removal of typed end-points for bulk, search, index APIs (#3524) (#3528)" This reverts commit fc8803f. * Revert "[Type removal] Ignore _type field in bulk request (#3504)" This reverts commit 5bd7236. Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize
pushed a commit
that referenced
this pull request
Jun 10, 2022
* Revert "Revert removal of typed end-points for bulk, search, index APIs (#3524)" This reverts commit f48043b. * Revert "[Type removal] Ignore _type field in bulk request (#3505)" This reverts commit a93ff13. Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.0
Backport to 2.0 branch
backwards-compatibility
bug
Something isn't working
v2.1.0
Issues and PRs related to version 2.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Suraj Singh surajrider@gmail.com
Description
As a follow up of #3505; add typed end-points for bulk, search, index APIs. This change simply consumes type param (if any) without passing it to corresponding request object.
Issues Resolved
#3484
Related
#3505
#3528
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.