-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes for version 2.1.0 #3773
Add release notes for version 2.1.0 #3773
Conversation
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
|
||
#### Upgrades | ||
|
||
* [Upgrade] Lucene-9.3.0-snapshot-b7231bb (#3537) ([#3555](https://github.com/opensearch-project/opensearch/pull/3555)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to mention these incremental snapshot commits (that have since been changed) in release notes. Instead we can mention the upgrade to 9.2.0 with 157e693.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Restore renaming method onMaster() and offMaster() in interface LocalNodeMasterListener ([#3687](https://github.com/opensearch-project/opensearch/pull/3687)) | ||
* Revert renaming masterOperation() to clusterManagerOperation() ([#3682](https://github.com/opensearch-project/opensearch/pull/3682)) | ||
* Restore AcknowledgedResponse and AcknowledgedRequest to package org.opensearch.action.support.master (#3669) ([#3670](https://github.com/opensearch-project/opensearch/pull/3670)) | ||
* Remove class org.opensearch.action.support.master.AcknowledgedResponse (#3662) ([#3668](https://github.com/opensearch-project/opensearch/pull/3668)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the L30-33? (PR 3668 3670 3682 3687)
They are used for reverting a few wrong changes, and those changes have not been released yet. 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thanks @tlfeng , that makes sense to remove them as they are just revert of wrong changes
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
@@ -0,0 +1,77 @@ | |||
## 2022-07-05 Version 2.1.0 Release Notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious how this list is generated ?
Is it manual today?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was following the steps mentioned by @peternied here to just generate the list of all commit. And yes we still have to manually go through each PR and filter out it into either of the sections (like Enhancements/bug fixes/Maintainance)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rishikesh1159 Glad to see this documentation was useful. What do you think about amending your commit message to include these steps as well, like from 2b92ca9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah sure that's a good idea. Let me amend my commit
…rate release notes. How to repeat: * `git checkout origin/2.0` * `git log --pretty=format:"* %s" --since=origin/2.0 > release-notes/opensearch-security.release-notes-2.0.0.0-rc1.md` * Manually organize file sections * Add Date / Version section (copy + modify from previous release) * Enhancements/Bug fixes/Maintenance * Replace pull request ids with full urls via regex * Find: `\(#(\d+)\)$` * Replace: `([#$1](https://github.com/opensearch-project/opensearch/pull/$1))` * Commit with these steps / modified with additional details Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
…9/OpenSearch into 2.1.0-release-notes
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
|
||
#### Remove Mapping types | ||
|
||
* [Type removal] Ignore _type field in bulk request ([#3505](https://github.com/opensearch-project/opensearch/pull/3505)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit was reverted as part of #3560 (below). We can remove this commit along with 3560.
* Add flat_skew setting to node overload decider (#3563) ([#3582](https://github.com/opensearch-project/opensearch/pull/3582)) | ||
* Revert beat types changes 2x ([#3560](https://github.com/opensearch-project/opensearch/pull/3560)) | ||
* Revert "[Remove] MainResponse version override cluster setting (#3031) (#3032)" ([#3530](https://github.com/opensearch-project/opensearch/pull/3530)) | ||
* Revert removal of typed end-points for bulk, search, index APIs ([#3524](https://github.com/opensearch-project/opensearch/pull/3524)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was reverted as part of #3560. We can remove this commit along with 3560
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove few commits (and their reverts) as it will confuse the audience. We followed same for 2.0.1 release.
* Fix NPE when minBound/maxBound is not set before being called. (#3605) ([#3610](https://github.com/opensearch-project/opensearch/pull/3610)) | ||
* Fix for bug showing incorrect awareness attributes count in AwarenessAllocationDecider (#3428) ([#3580](https://github.com/opensearch-project/opensearch/pull/3580)) | ||
* Add flat_skew setting to node overload decider (#3563) ([#3582](https://github.com/opensearch-project/opensearch/pull/3582)) | ||
* Revert beat types changes 2x ([#3560](https://github.com/opensearch-project/opensearch/pull/3560)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed as it is revert commit.
* Fix for bug showing incorrect awareness attributes count in AwarenessAllocationDecider (#3428) ([#3580](https://github.com/opensearch-project/opensearch/pull/3580)) | ||
* Add flat_skew setting to node overload decider (#3563) ([#3582](https://github.com/opensearch-project/opensearch/pull/3582)) | ||
* Revert beat types changes 2x ([#3560](https://github.com/opensearch-project/opensearch/pull/3560)) | ||
* Revert "[Remove] MainResponse version override cluster setting (#3031) (#3032)" ([#3530](https://github.com/opensearch-project/opensearch/pull/3530)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should highlight this commit to signify that 2.1 supports version spoofing against 2.0.0 where it was removed. This temporary fix allows external clients such as beats (broken without this commit; more details in 3484) to work with OpenSearch engine.
I think out of existing sections, it belongs to feature/enhancement section though technically it is a workaround to work with external clients.
pretty bad, the notes for v2.0.0 are also missing. 😕 the links from GitHub release are 404 because of this. |
How to repeat: * `git checkout origin/2.0` * `git log --pretty=format:"* %s" --since=3-23-2022 > release-notes/opensearch.release-notes-2.1.0.md` * Manually organize file sections * Add Date / Version section (copy + modify from previous release) * Enhancements/Bug fixes/Maintenance * Replace pull request ids with full urls via regex * Find: `\(#(\d+)\)$` * Replace: `([#$1](https://github.com/opensearch-project/opensearch/pull/$1))` * Commit with these steps / modified with additional details Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
…9/OpenSearch into 2.1.0-release-notes. How to repeat: * `git checkout origin/2.1` * `git log --pretty=format:"* %s" --since=3-23-2022 > release-notes/opensearch.release-notes-2.1.0.md` * Manually organize file sections * Add Date / Version section (copy + modify from previous release) * Enhancements/Bug fixes/Maintenance * Replace pull request ids with full urls via regex * Find: `\(#(\d+)\)$` * Replace: `([#$1](https://github.com/opensearch-project/opensearch/pull/$1))` * Commit with these steps / modified with additional details Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
How to repeat: * `git checkout origin/2.1` * `git log --pretty=format:"* %s" --since=3-23-2022 > release-notes/opensearch.release-notes-2.1.0.md` * Manually organize file sections * Add Date / Version section (copy + modify from previous release) * Enhancements/Bug fixes/Maintenance * Replace pull request ids with full urls via regex * Find: `\(#(\d+)\)$` * Replace: `([#$1](https://github.com/opensearch-project/opensearch/pull/$1))` * Commit with these steps / modified with additional details Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
@viceice the release notes for 2.0 is working for me: https://github.com/opensearch-project/OpenSearch/blob/main/release-notes/opensearch.release-notes-2.0.0.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Rishikesh1159 for taking care of this.
Could you list down the process you've taken to generate this list?
There are a couple of open issues which track this problem:
#1868
#789
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @saratvemulapalli , @dreamer-89 for quick reviews. Sure Sarat I will list down the process to generate release notes in those issues. |
Waiting for gradle check to pass before merging this PR |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #3773 +/- ##
=======================================
Coverage ? 70.46%
Complexity ? 56615
=======================================
Files ? 4557
Lines ? 272681
Branches ? 40038
=======================================
Hits ? 192153
Misses ? 64308
Partials ? 16220 Continue to review full report at Codecov.
|
Gradle Check (Jenkins) Run Completed with:
|
* Removing unused method from TransportSearchAction (#3437) ([#3445](https://github.com/opensearch-project/opensearch/pull/3445)) | ||
* Fix Lucene-snapshots repo for jdk 17. (#3396) ([#3404](https://github.com/opensearch-project/opensearch/pull/3404)) | ||
* Temporary adding Apache Lucene repositories for snapshots (#3042) ([#3047](https://github.com/opensearch-project/opensearch/pull/3047)) | ||
* [Remove] MainResponse version override cluster setting (#3031) ([#3032](https://github.com/opensearch-project/opensearch/pull/3032)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was removed & then reverted, It does not need to be in these notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was removed in 2.0.0, and recently reverted (added back) for 2.0.1. Shouldn't this commit be included as it was missing in 2.0.0 ?
## 2022-07-07 Version 2.1.0 Release Notes | ||
|
||
|
||
### Breaking Changes in 2.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of these changes appear to be breaking to me, this looks like copy/paste error, we should update and remove this.
Sorry for incorrectly adding Breaking changes Heading in this PR. Breaking changes only happen in major versions. I put out a PR for fixing this #3817 |
🤔 Can't find it anymore. maybe i made a mistake. Thanks for new releasenotes for v2.1. Maybe those should be created automatically on release, so we don't get those 404 when checking for new releases until the notes file is pushed. |
* Adding release notes for opensearch 2.1.0 How to repeat: * `git checkout origin/2.1` * `git log --pretty=format:"* %s" --since=3-23-2022 > release-notes/opensearch.release-notes-2.1.0.md` * Manually organize file sections * Add Date / Version section (copy + modify from previous release) * Enhancements/Bug fixes/Maintenance * Replace pull request ids with full urls via regex * Find: `\(#(\d+)\)$` * Replace: `([#$1](https://github.com/opensearch-project/opensearch/pull/$1))` * Commit with these steps / modified with additional details Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> (cherry picked from commit c08e5ac)
* Adding release notes for opensearch 2.1.0 How to repeat: * `git checkout origin/2.1` * `git log --pretty=format:"* %s" --since=3-23-2022 > release-notes/opensearch.release-notes-2.1.0.md` * Manually organize file sections * Add Date / Version section (copy + modify from previous release) * Enhancements/Bug fixes/Maintenance * Replace pull request ids with full urls via regex * Find: `\(#(\d+)\)$` * Replace: `([#$1](https://github.com/opensearch-project/opensearch/pull/$1))` * Commit with these steps / modified with additional details Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> (cherry picked from commit c08e5ac) Co-authored-by: Rishikesh Pasham <62345295+Rishikesh1159@users.noreply.github.com>
Description
This commit adds the release notes for the v2.1.0 Release starting from 2.x version bump to 2.1.
Issues Resolved
part of #3636
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.