List all PITs service layer changes #4016

bharath-techie · 2022-07-26T19:09:39Z

Description

Changes to list all active point in time searches to the user. This contains only the service layer changes and rest layer changes will come in later.

Request:
localhost:9200/_search/point_in_time/all

Response:

    "pits": [
        {
            "pitId": "o463QQEPbXktaW5kZXgtMDAwMDAxFjFrNGx0U1owUk5TVU9yYzlLN3VtbXcAFndiVnlzZEJPVFpHVEl6M0VvYldoU2cAAAAAAAAAAAEWczlEZVhDeUVUcXlzcXZ2RDVhNjd0QQEWMWs0bHRTWjBSTlNVT3JjOUs3dW1tdwAA",
            "creationTime": 1657724278549,
            "keepAlive": 6000000
        },
        {
            "pitId": "o463QQEPbXktaW5kZXgtMDAwMDAxFjFrNGx0U1owUk5TVU9yYzlLN3VtbXcAFndiVnlzZEJPVFpHVEl6M0VvYldoU2cAAAAAAAAAAAIWczlEZVhDeUVUcXlzcXZ2RDVhNjd0QQEWMWs0bHRTWjBSTlNVT3JjOUs3dW1tdwAA",
            "creationTime": 1657724568298,
            "keepAlive": 82800000
        }
    ]
}

'Include all' flag as part of request will also show node results and failures on top of the above response, which will be handled in rest layer.

Issues Resolved

#1147

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

…ch into deletepitservice

github-actions · 2022-07-26T19:10:59Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1006/
CommitID: f9811bec5682d13a669f1e1889668b722b8e7a28

github-actions · 2022-07-26T19:19:39Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1007/
CommitID: 652b4ab7eeaf3b2466fa6e84f1942925a1734ca9

github-actions · 2022-07-27T04:40:14Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1027/
CommitID: a0216d10091b86c8a66764764e3b88992286e091

github-actions · 2022-07-27T04:51:05Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1029/
CommitID: 028245871f4ee919b282e7e65e33405afd420d7d

github-actions · 2022-07-27T05:17:11Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1030/
CommitID: 7f78b0b3cf39a00326ab95695abc5967ca742d12

github-actions · 2022-07-27T06:06:16Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1033/
CommitID: d69e5d97b1ed592367a0610c5af5d08b6710599d

bharath-techie · 2022-07-27T16:07:09Z

@andrross @reta please take a look at this PR

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

github-actions · 2022-07-27T16:10:01Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1042/
CommitID: 17fffdc

reta · 2022-07-27T18:59:50Z

server/src/main/java/org/opensearch/action/search/GetAllPitNodeRequest.java

+public class GetAllPitNodeRequest extends BaseNodeRequest {
+    GetAllPitNodesRequest request;
+
+    @Inject


@Inject seems to be not needed here, right?

reta · 2022-07-27T19:10:39Z

server/src/main/java/org/opensearch/action/search/GetAllPitNodeRequest.java

+ * Inner node get all pits request
+ */
+public class GetAllPitNodeRequest extends BaseNodeRequest {
+    GetAllPitNodesRequest request;


How request is used? I have not found any references to it ...

reta · 2022-07-27T19:11:56Z

server/src/main/java/org/opensearch/action/search/GetAllPitNodeResponse.java

+     */
+    private List<ListPitInfo> pitsInfo;
+
+    @Inject


Same, I believe @Inject serves no purpose here, does it?

reta · 2022-07-27T19:13:08Z

server/src/main/java/org/opensearch/action/search/GetAllPitNodeResponse.java

+    private List<ListPitInfo> pitsInfo;
+
+    @Inject
+    public GetAllPitNodeResponse(StreamInput in, List<ListPitInfo> pitsInfo) throws IOException {


Btw, is this constructor even needed?

reta · 2022-07-27T19:15:44Z

server/src/main/java/org/opensearch/action/search/GetAllPitNodesResponse.java

+    /**
+     * List of unique PITs across all nodes
+     */
+    List<ListPitInfo> pitsInfo = new ArrayList<>();


Shouldn't be private?

reta · 2022-07-27T19:19:33Z

server/src/main/java/org/opensearch/action/search/GetAllPitNodesResponse.java

+    }
+
+    public List<ListPitInfo> getPITIDs() {
+        return new ArrayList<>(pitsInfo);


Collections.unmodifiableList(pitsInfo)?

reta · 2022-07-27T19:29:25Z

server/src/main/java/org/opensearch/action/search/PitService.java

+            DiscoveryNode node = cursor.value;
+            nodes.add(node);
+        }
+        DiscoveryNode[] disNodesArr = new DiscoveryNode[nodes.size()];


Minor, a bit more compact notation:

DiscoveryNode[] disNodesArr = nodes.toArray(new DiscoveryNode[nodes.size()]);

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

github-actions · 2022-07-28T03:54:29Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1063/
CommitID: c2419b8

… into listallpitservice

github-actions · 2022-08-02T11:02:09Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/1256/
CommitID: aa0eafc

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

reta · 2022-08-02T13:06:11Z

server/src/main/java/org/opensearch/action/search/GetAllPitNodesResponse.java

+     */
+    private final Set<ListPitInfo> pitInfos = new HashSet<>();
+
+    @Inject


I thought we cleaned all unnecessary @Inject, left overs?

github-actions · 2022-08-02T13:29:04Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/1262/
CommitID: 911cd55

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

github-actions · 2022-08-02T14:50:18Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1267/
CommitID: f7a0155

github-actions · 2022-08-02T16:01:57Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1274/
CommitID: 1634963303ce9237c817334187f5c9af70984b58

github-actions · 2022-08-02T16:33:51Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1276/
CommitID: 7779b9788826cb620835e8baa5208a2abd8a5ea7

… into listallpitservice

github-actions · 2022-08-02T17:13:59Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/1280/
CommitID: ba620c7

github-actions · 2022-08-03T03:23:33Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1322/
CommitID: 8e58f97

… into listallpitservice

github-actions · 2022-08-03T04:19:09Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/1326/
CommitID: a6c073f

Bukhtawar

Let's clearly document the current limitations with delete and List PIT for now.

bharath-techie added 2 commits July 21, 2022 11:04

List all pits service layer changes

245b40b

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

Merge branch 'deletepitservice' of github.com:bharath-techie/OpenSear…

28aab30

…ch into deletepitservice

bharath-techie force-pushed the listallpitservice branch from f9811be to 652b4ab Compare July 26, 2022 19:15

bharath-techie force-pushed the listallpitservice branch from 652b4ab to a0216d1 Compare July 27, 2022 04:35

bharath-techie force-pushed the listallpitservice branch from a0216d1 to 0282458 Compare July 27, 2022 04:45

bharath-techie marked this pull request as ready for review July 27, 2022 04:48

bharath-techie requested review from a team and reta as code owners July 27, 2022 04:48

bharath-techie force-pushed the listallpitservice branch from 0282458 to 7f78b0b Compare July 27, 2022 05:14

bharath-techie force-pushed the listallpitservice branch from 7f78b0b to d69e5d9 Compare July 27, 2022 06:04

dhruv16dhr mentioned this pull request Jul 27, 2022

[META] Point In Time Search Issue List #3959

Open

47 tasks

Get all pits service layer changes

17fffdc

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

bharath-techie force-pushed the listallpitservice branch from d69e5d9 to 17fffdc Compare July 27, 2022 16:07

reta reviewed Jul 27, 2022

View reviewed changes

Addressing review comments

c2419b8

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

Merge branch 'main' of https://github.com/opensearch-project/OpenSearch…

aa0eafc

… into listallpitservice

Fixing pit flaky tests

911cd55

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

reta reviewed Aug 2, 2022

View reviewed changes

Addressing comment

f7a0155

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

reta approved these changes Aug 2, 2022

View reviewed changes

bharath-techie force-pushed the listallpitservice branch from 1634963 to 7779b97 Compare August 2, 2022 16:04

Merge branch 'main' of https://github.com/opensearch-project/OpenSearch…

ba620c7

… into listallpitservice

bharath-techie force-pushed the listallpitservice branch from 7779b97 to ba620c7 Compare August 2, 2022 16:49

Merge branch 'main' of https://github.com/opensearch-project/OpenSearch…

a6c073f

… into listallpitservice

bharath-techie force-pushed the listallpitservice branch from 8e58f97 to a6c073f Compare August 3, 2022 03:54

Bukhtawar approved these changes Aug 3, 2022

View reviewed changes

Bukhtawar merged commit 6f43dbc into opensearch-project:main Aug 3, 2022

bharath-techie mentioned this pull request Aug 3, 2022

Point in time security changes opensearch-project/security#1989

Merged

3 tasks

bharath-techie mentioned this pull request Aug 17, 2022

Add security changes for point in time API opensearch-project/security#2033

Merged

3 tasks

bharath-techie mentioned this pull request Sep 5, 2022

[Backport 2.x] [Point in time] Backport point in time changes #4406

Closed

6 tasks

bharath-techie mentioned this pull request Sep 28, 2022

[Backport 2.x] [Point in time] Backport point in time changes #4616

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

List all PITs service layer changes #4016

List all PITs service layer changes #4016

bharath-techie commented Jul 26, 2022 •

edited

Loading

github-actions bot commented Jul 26, 2022

github-actions bot commented Jul 26, 2022

github-actions bot commented Jul 27, 2022

github-actions bot commented Jul 27, 2022

github-actions bot commented Jul 27, 2022

github-actions bot commented Jul 27, 2022

bharath-techie commented Jul 27, 2022

github-actions bot commented Jul 27, 2022

reta Jul 27, 2022

reta Jul 27, 2022

reta Jul 27, 2022

reta Jul 27, 2022

reta Jul 27, 2022

reta Jul 27, 2022

reta Jul 27, 2022

github-actions bot commented Jul 28, 2022

github-actions bot commented Aug 2, 2022

reta Aug 2, 2022

github-actions bot commented Aug 2, 2022

github-actions bot commented Aug 2, 2022

github-actions bot commented Aug 2, 2022

github-actions bot commented Aug 2, 2022

github-actions bot commented Aug 2, 2022

github-actions bot commented Aug 3, 2022

github-actions bot commented Aug 3, 2022

Bukhtawar left a comment

List all PITs service layer changes #4016

List all PITs service layer changes #4016

Conversation

bharath-techie commented Jul 26, 2022 • edited Loading

Description

Issues Resolved

Check List

github-actions bot commented Jul 26, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 26, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 27, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 27, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 27, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 27, 2022

Gradle Check (Jenkins) Run Completed with:

bharath-techie commented Jul 27, 2022

github-actions bot commented Jul 27, 2022

Gradle Check (Jenkins) Run Completed with:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jul 28, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

Choose a reason for hiding this comment

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Aug 3, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Aug 3, 2022

Gradle Check (Jenkins) Run Completed with:

Bukhtawar left a comment

Choose a reason for hiding this comment

bharath-techie commented Jul 26, 2022 •

edited

Loading